step by step agent instructions don't work with 3.8.0 on ubuntu

[clutchski]

Following the step by step instructions on the web didn't work. To reproduce, follow these steps:

• Do this https://app.datadoghq.com/account/settings#agent/ubuntu
• apt-get install restarts the agent, but with no config all the supervisor processes are failing.
• After adding the config file and restarting we get a Error: Another program is already listening on a port that one of our HTTP servers is configured to use. Shut this program down first before starting supervisord. message.
• The other issue is that after calling stop, our supervisor process is still running. This shouldn't be the case. Calling stop should kill all dd-agent processes. For example:

vagrant@lucid32:~$ sudo /etc/init.d/datadog-agent stop
 * Stopping Datadog agent (stopping supervisord) datadog-agent                                                                                                                                                                                                                                                       [ OK ]
vagrant@lucid32:~$ ps aux | grep dd-agent
root      1366  0.0  1.9  12120  7308 ?        Ss   22:05   0:00 /usr/bin/python /usr/bin/supervisord -c /etc/dd-agent/supervisor.conf --pidfile /var/run/datadog-supervisord.pid
vagrant   1740  0.0  0.2   2196   800 pts/0    S+   22:13   0:00 grep --color=auto dd-agent

Expected:

• things just work:

Details:

• os: lucid32
• package: datadog-agent

Also make sure that this works with the other packages and the other OS's.

[elijahandrews]

In testing and review.

[elijahandrews]

The problem was that the init script didn't check if the datadog configuration was present before starting supervisor. So when the post installation script started the agent for the first time (before the user had a chance to run the sed command to populate the datadog configuration file), the supervisor would start and launch the datadog processes, which would all fail because the config file wasn't present. This sent the agent into a bad state.

This problem affected Debian and Red Hat packaging.

[elijahandrews]

Fixed in 3.8.0.