dd-agent fails to get gunicorn process on linux

[nxvl]

dd-agent try to gets unicorn master process by name using this line [1]:

   return  "gunicorn: master [%s]" % name

However, psutil trims the process name removing spaces, in this line [2]:

  name = f.read().split(' ')[1].replace('(', '').replace(')', '')

which return "gunicorn:" as process name, generating the following error:

• instance #0 [ERROR]: GUnicornCheckError('Found no master process with name: gunicorn: master [PROCESS_NAME]',)

1. https://github.com/DataDog/dd-agent/blob/master/checks.d/gunicorn.py#L129
2. https://code.google.com/p/psutil/source/browse/psutil/_pslinux.py#472

[clutchski]

Thanks for reporting. Two questions:

• Can you run ps aux | grep gunicorn on your system?
• Did you set the proc_name in the gunicorn config to match that? i.e. here https://github.com/DataDog/dd-agent/blob/master/conf.d/gunicorn.yaml.example#L10

[nxvl]

The line returned by f.read() looks like this:
'13979 (gunicorn: maste) S 1 13979 13979 0 -1 4202752 10282 3030 0 0 44 18 0 0 20 0 1 0 6171640 81555456 5808 18446744073709551615 4194304 6749740 140736594413936 140736594358920 140083335243587 0 0 16781312 137447943 18446744071580459545 0 0 17 0 0 0 0 0 0\n'
Linux trims the process name to 15 characters, making it imposible to match with the process full name.

[nxvl]

Sure, this is ps | aux

root 13979 0.0 3.8 79644 23232 ? Ss 16:38 0:00 gunicorn: master [PROCESS_NAME]
USER 13994 0.0 4.3 84868 26308 ? S 16:38 0:00 gunicorn: worker [PROCESS_NAME]
USER 13995 0.0 4.3 84880 26320 ? S 16:38 0:00 gunicorn: worker [PROCESS_NAME]
USER 13996 0.0 4.3 84892 26328 ? S 16:38 0:00 gunicorn: worker [PROCESS_NAME]

Configuring the proc name as of that example won't help, since it will only change the value of PROCESS_NAME, which isn't shown by psutil

[nxvl]

import psutil
[p.name for p in psutil.process_iter() if p.name == 'gunicorn:']
['gunicorn:', 'gunicorn:', 'gunicorn:', 'gunicorn:']

[nxvl]

p.cmldine returns ['gunicorn: master [PROCESS_NAME]'] which is what dd-agent is looking for

[nxvl]

Changing [1]:

        master_procs = [p for p in psutil.process_iter() if p.name == master_name]

For:

        master_procs = [p for p in psutil.process_iter() if p.cmdline and p.cmdline[0] == master_name]

Fixed the issue for me.

1. https://github.com/DataDog/dd-agent/blob/master/checks.d/gunicorn.py#L114

[clutchski]

Ok great. Thank for digging into that. We'll include it in our next release.

[nxvl]

The dashboard still shows the process as "gunicorn:" (doesn't hurt, just letting you know)

[remh]

Thanks @nxvl !

[ghost]

For the posteriors,

I was having trouble getting these to work and realized I didn't have the necessary setproctitle pip package installed in the gunicorn env. This package makes the gunicorn --name field actually work instead of silently fail.

[ramtinms]

sudo /usr/local/bin/pip install psutil solved my problem