Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation fails with Datadog SDK 1.3.0 using Cocoapods and Xcode 11.3.1 #214

Closed
provTheodoreNewell opened this issue Aug 12, 2020 · 4 comments
Assignees
Labels
compilation issue SDK doesn't compile or gives warnings.
Milestone

Comments

@provTheodoreNewell
Copy link

provTheodoreNewell commented Aug 12, 2020

The issue

Compilation fails with 5 issues in a new Xcode 11.3.1 project with DataDog SDK 1.3.0:

  1. Value of type 'FileHandle' has no member 'seekToEnd' in File.swift line 62
  2. Extraneous argument label 'contentsOf:' in call in File.swift line 63
  3. Compiler-suggested fix: Replace 'contentsOf: ' with ''
  4. Value of type 'FileHandle' has no member 'readToEnd' in File.swift line 94
  5. Ambiguous reference to member 'swizzle(using:)' in URLSessionSwizzler.swift line 68
  6. Ambiguous reference to member 'swizzle(using:)' in URLSessionSwizzler.swift line 109

Datadog SDK version: 1.3.0

Last working Datadog SDK version: 1.2.4

Dependency Manager: Cocoapods 1.9.3

Other toolset: n/a

Xcode version: Xcode 11.3.1 (11C505)

Swift version: 5.1.3 (swiftlang-1100.0.282.1 clang-1100.0.33.15)

Deployment Target: iOS 13.2, iPhone + iPad

macOS version: macOS Catalina 10.15.5 (19F101)

@provTheodoreNewell provTheodoreNewell added the compilation issue SDK doesn't compile or gives warnings. label Aug 12, 2020
@buranmert buranmert self-assigned this Aug 13, 2020
@buranmert
Copy link
Contributor

hey @provTheodoreNewell 👋 thanks for reporting the issue!
we made a fix and are planning to ship it as a hotfix
i'll keep you posted once this is done

The issue

we use some FileHandle methods which are only available in iOS 13.4+ and Xcode 11.3.1 has an inferior base SDK version
as a fix, we wrap this code with #if compiler(>=5.2) ... #else ... #endif; compiler(5.2) means Xcode 11.4 whose base SDK is iOS 13.4
in your case, Xcode 11.3.1, compiler shouldn't see those new methods and should compile the #else scope

@provTheodoreNewell
Copy link
Author

Thank you!

@buranmert
Copy link
Contributor

hi @provTheodoreNewell 👋
1.3.1 hotfix version is shipped to fix the issue 🚀

please let me know if the issue persists, otherwise feel free to close the issue

@buranmert buranmert added the awaiting response Waiting for response / confirmation from the reporter label Aug 14, 2020
@provTheodoreNewell
Copy link
Author

Resolved: 1.3.1 compiles with Xcode 11.3.1 🥳

@buranmert buranmert added this to the hotfix-1.3.1 milestone Aug 19, 2020
@ncreated ncreated removed the awaiting response Waiting for response / confirmation from the reporter label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compilation issue SDK doesn't compile or gives warnings.
Projects
None yet
Development

No branches or pull requests

3 participants