RUMM-1112 Tracing to Logging integration improved #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration passes Error object to Logger via public API Before the parameters were passed by internal fields
buranmert
force-pushed
the
buranmert/RUMM-1112-improve-logged-span-errors
branch
from
41320de
to
8b37eca
Compare
ncreated
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Similar to #423 Tracing integration too was written before new Logger API
It was passing Span information through internal attributes
How?
Now Tracing integration passes
DDErrordirectly to LoggingThat change adds
error.messagefield to the Log as seen belowBefore
After
Review checklist