-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Clarify Expo Support #48
Comments
For what is worth @brookemitchell I also ran into this issue and continue to receive the same error when running the app on an ejected workflow or even on a "vanilla" react-native application. I'm still waiting to hear back from DD live support to figure out how to initialize the SDK for a react-native application of any stripe. |
Hello @brookemitchell and @chunkzer! Thanks for submitting the issue. We didn't look yet at the Expo compatibility, but will definitely check it out. @chunkzer Can you please give us more details regarding you issue with "vanilla" application. Do you mean the app which is made without Expo (pure React Native app)? If so, can you please share what Datadog React Native SDK version you are using, does it happen only for iOS, or for Android as well? If it is iOS app, then does it have pure |
Same issue here... |
Hello @0xnm An update on my current status with this. I've managed to get the library running as part of an expo bare-workflow (that would be with access to the iOS side of the project with Xcode, etc...) as well as with a vanilla react-native app. Here's my step by step process to get to this point (Relevant point is that this is react-native 0.63):
Relevant issues: Run Now you’ll need to follow the instructions detailed on: (I realized the issue is pinned but is there a way for it to have more visibility until fixed?) At this point I'm able to build my application and execute a block like this one:
Still I'm not seeing any activity on the relevant dashboard. |
Hi @brookemitchell; This is a relevant issue. Wondering, why was this closed without much conclusion - any redirection or follow-ups?! Especially with relevance to the expo-managed workflow?! Thanks. Update - found that there are open threads here - |
@astriskit sorry way later, indeed this is working excellently for us with an expo eas build, see: #47 (comment) |
Hey folks, I'm the PM for RUM at Datadog, thank you for the feature request. We're investigating integration with Expo managed workflow and we would love to get insights on your experience. If you're open to a quick chat, please reach out support@datadoghq.com and mention this issue. |
Hi all, For now, there is no need to add plugins ;) |
Our company currently uses the Expo managed workflow, it looks as though
dd-sdk-react-native
requires access to react-native 'Native Modules' which is fair enough 😆 I'm expecting the sdk requires me to eject to the Expo 'bare' workflow.In the Expo managed workflow I get this error when trying to initialise.
It would be useful to us if in the docs you stated whether the 'Expo Managed Workflow' is supported.
It seems reasonable if it's not. Later in the year Expo is planning to add native module support with EAS build https://blog.expo.io/expo-managed-workflow-in-2021-d1c9b68aa10
Describe the solution you'd like
An update to the docs stating expo support. Or an option to use dd-sdk with the Expo Managed workflow
Describe alternatives you've considered
Eject expo, or wait for runtime customisation in expo to give native module support
The text was updated successfully, but these errors were encountered: