[APM] Made native definition lists temporary (#6417)

## Summary of changes
Move native definitions from a permanent list to a temporary one that
gets created and freed on demand

## Reason for change
Some crashes were reported in shutdown and it points to definition lists
cleanup

## Implementation details
Instead of storing the lists as static fields, they get created in the
call to GetCallSites and GetCallTargets and destroyed right after
they've been read by the profiler

## Test coverage

## Other details
<!-- Fixes #{issue} -->

<!-- ⚠️ Note: where possible, please obtain 2 approvals prior to
merging. Unless CODEOWNERS specifies otherwise, for external teams it is
typically best to have one review from a team member, and one review
from apm-dotnet. Trivial changes do not require 2 reviews. -->

Author: daniel-romano-DD

tracer/build/_build/CodeGenerators/CallSitesGenerator.cs

@@ -258,13 +258,13 @@ internal static void GenerateFile(Dictionary<string, AspectClass> aspectClasses,
                 // This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
                 // </copyright>
                 // <auto-generated/>
-                #pragma once
                 #include "generated_definitions.h"
 
                 namespace trace
                 {
-
-                std::vector<WCHAR*> g_callSites=
+                int GeneratedDefinitions::InitCallSites(UINT32 enabledCategories, UINT32 platform)
+                {
+                std::vector<WCHAR*> callSites =
                 {
                 """);
 
@@ -298,12 +298,14 @@ namespace trace
 
             sb.AppendLine("""
                 };
+                return trace::profiler->RegisterIastAspects((WCHAR**) callSites.data(), callSites.size(), enabledCategories, platform);
+                }
                 }
                 """);
 
 
             if (!Directory.Exists(outputPath)) { Directory.CreateDirectory(outputPath); }
-            var fileName = outputPath / "generated_callsites.g.h";
+            var fileName = outputPath / "generated_callsites.g.cpp";
             File.WriteAllText(fileName, sb.ToString());
 
             Logger.Information("CallSite definitions File saved: {File}", fileName);

tracer/build/_build/CodeGenerators/CallTargetsGenerator.cs

@@ -510,11 +510,12 @@ internal static void GenerateNativeFile(Dictionary<CallTargetDefinitionSource, T
                 // This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
                 // </copyright>
                 // <auto-generated/>
-                #pragma once
                 #include "generated_definitions.h"
 
                 namespace trace
                 {
+                int GeneratedDefinitions::InitCallTargets(UINT32 enabledCategories, UINT32 platform)
+                {
                 """);
 
             var assemblyName = $"Datadog.Trace, Version={version}.0, Culture=neutral, PublicKeyToken=def86d061d0d2eeb";
@@ -548,7 +549,9 @@ namespace trace
             //Write all CallTargets
             bool inWin32Section = false;
             sb.AppendLine();
-            sb.AppendLine("std::vector<CallTargetDefinition3> g_callTargets=");
+            sb.AppendLine("""
+                std::vector<CallTargetDefinition3> callTargets =
+                """);
             sb.AppendLine("{");
             int x = 0;
             foreach (var definition in definitions
@@ -580,12 +583,14 @@ namespace trace
 
             sb.AppendLine("""
                 };
+                return profiler->RegisterCallTargetDefinitions((WCHAR*) WStr("Tracing"), callTargets.data(), callTargets.size(), enabledCategories, platform);
+                }
                 }
                 """);
 
 
             if (!Directory.Exists(outputPath)) { Directory.CreateDirectory(outputPath); }
-            var fileName = outputPath / "generated_calltargets.g.h";
+            var fileName = outputPath / "generated_calltargets.g.cpp";
             File.WriteAllText(fileName, sb.ToString());
 
             Logger.Information("CallTarget definitions File saved: {File}", fileName);
@@ -603,7 +608,7 @@ static string GetSignature(CallTargetDefinitionSource definition)
 
             static string GetSignatureName(int index)
             {
-                return $"g_callTargets_Sig_{index:000}";
+                return $"sig{index:000}";
             }
 
             static string GetSignatureField(string signatureName, string signature)

tracer/src/Datadog.Tracer.Native/CMakeLists.txt

@@ -208,7 +208,8 @@ add_library("Datadog.Tracer.Native.static" STATIC
         tracer_integration_definition.cpp
         tracer_method_rewriter.cpp
         tracer_rejit_preprocessor.cpp
-        Generated/generated_definitions.cpp
+        Generated/generated_callsites.g.cpp
+        Generated/generated_calltargets.g.cpp
 )
 
 set_target_properties("Datadog.Tracer.Native.static" PROPERTIES PREFIX "")

tracer/src/Datadog.Tracer.Native/Datadog.Tracer.Native.vcxproj

@@ -283,8 +283,8 @@
     <ClInclude Include="fault_tolerant_rewriter.h" />
     <ClInclude Include="fault_tolerant_tracker.h" />
     <ClInclude Include="function_control_wrapper.h" />
-    <ClInclude Include="Generated\generated_callsites.g.h" />
-    <ClInclude Include="Generated\generated_calltargets.g.h" />
+    <ClCompile Include="Generated\generated_callsites.g.cpp" />
+    <ClCompile Include="Generated\generated_calltargets.g.cpp" />
     <ClInclude Include="Generated\generated_definitions.h" />
     <ClInclude Include="iast\hardcoded_secrets_method_analyzer.h" />
     <ClInclude Include="iast\app_domain_info.h" />
@@ -369,7 +369,6 @@
     <ClCompile Include="fault_tolerant_rewriter.cpp" />
     <ClCompile Include="fault_tolerant_tracker.cpp" />
     <ClCompile Include="function_control_wrapper.cpp" />
-    <ClCompile Include="Generated\generated_definitions.cpp" />
     <ClCompile Include="iast\hardcoded_secrets_method_analyzer.cpp" />
     <ClCompile Include="iast\aspect.cpp" />
     <ClCompile Include="iast\aspect_filter.cpp" />

tracer/src/Datadog.Tracer.Native/Datadog.Tracer.Native.vcxproj.filters

@@ -116,8 +116,9 @@
     <ClCompile Include="iast\hardcoded_secrets_method_analyzer.cpp">
       <Filter>Iast</Filter>
     </ClCompile>
-    <ClCompile Include="Generated\generated_definitions.cpp" />
     <ClCompile Include="signature_builder.cpp" />
+    <ClCompile Include="Generated\generated_callsites.g.cpp" />
+    <ClCompile Include="Generated\generated_calltargets.g.cpp" />
   </ItemGroup>
   <ItemGroup>
     <ClInclude Include="calltarget_tokens.h" />
@@ -269,8 +270,6 @@
     </ClInclude>
     <ClInclude Include="..\..\..\shared\src\native-src\version.h" />
     <ClInclude Include="Generated\generated_definitions.h" />
-    <ClInclude Include="Generated\generated_callsites.g.h" />
-    <ClInclude Include="Generated\generated_calltargets.g.h" />
     <ClInclude Include="signature_builder.h" />
   </ItemGroup>
   <ItemGroup>

tracer/src/Datadog.Tracer.Native/Generated/generated_callsites.g.h renamed to tracer/src/Datadog.Tracer.Native/Generated/generated_callsites.g.cpp

@@ -3,13 +3,13 @@
 // This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
 // </copyright>
 // <auto-generated/>
-#pragma once
 #include "generated_definitions.h"
 
 namespace trace
 {
-
-std::vector<WCHAR*> g_callSites=
+int GeneratedDefinitions::InitCallSites(UINT32 enabledCategories, UINT32 platform)
+{
+std::vector<WCHAR*> callSites =
 {
 (WCHAR*)WStr("[AspectClass(\"EntityFramework\",[None],Sink,[SqlInjection])] Datadog.Trace.Iast.Aspects.EntityCommandAspect 12"),
 (WCHAR*)WStr("  [AspectMethodInsertBefore(\"System.Data.Entity.Core.EntityClient.EntityCommand::ExecuteReader(System.Data.CommandBehavior)\",\"\",[1],[False],[None],Default,[])] ReviewSqlCommand(System.Object) 15"),
@@ -707,4 +707,6 @@ std::vector<WCHAR*> g_callSites=
 (WCHAR*)WStr("  [AspectMethodInsertBefore(\"System.Xml.XPath.Extensions::XPathSelectElements(System.Xml.Linq.XNode,System.String)\",\"\",[0],[False],[None],Default,[])] ReviewPath(System.String) 15"),
 (WCHAR*)WStr("  [AspectMethodInsertBefore(\"System.Xml.XPath.Extensions::XPathSelectElements(System.Xml.Linq.XNode,System.String,System.Xml.IXmlNamespaceResolver)\",\"\",[1],[False],[None],Default,[])] ReviewPath(System.String) 15"),
 };
+return trace::profiler->RegisterIastAspects((WCHAR**) callSites.data(), callSites.size(), enabledCategories, platform);
+}
 }