Skip to content

Commit 3b348df

Browse files
Remove testing of CallSite codepaths in WcfTests
1 parent 8820e7d commit 3b348df

11 files changed

+7
-429
lines changed

tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/WcfTests.cs

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -39,26 +39,24 @@ public static IEnumerable<object[]> GetData()
3939
{
4040
foreach (var binding in Bindings)
4141
{
42-
// When using the binding example, it is expected that CallSite or CallTarget w/ Old WCF fails,
43-
// so only include CallTarget w/ New WCF
42+
// When using the binding example, it is expected that Old WCF fails,
43+
// so only test New WCF
4444
if (binding == "Custom")
4545
{
46-
yield return new object[] { binding, true, true };
46+
yield return new object[] { binding, true };
4747
continue;
4848
}
4949

50-
yield return new object[] { binding, false, false };
51-
yield return new object[] { binding, true, false };
52-
yield return new object[] { binding, true, true };
50+
yield return new object[] { binding, false };
51+
yield return new object[] { binding, true };
5352
}
5453
}
5554

56-
5755
[SkippableTheory]
5856
[Trait("Category", "EndToEnd")]
5957
[Trait("RunOnWindows", "True")]
6058
[MemberData(nameof(GetData))]
61-
public async Task SubmitsTraces(string binding, bool enableCallTarget, bool enableNewWcfInstrumentation)
59+
public async Task SubmitsTraces(string binding, bool enableNewWcfInstrumentation)
6260
{
6361
if (enableNewWcfInstrumentation)
6462
{
@@ -82,7 +80,7 @@ public async Task SubmitsTraces(string binding, bool enableCallTarget, bool enab
8280
agent.SpanFilters.Add(s => !s.Resource.Contains("schemas.xmlsoap.org") && !s.Resource.Contains("www.w3.org"));
8381
var spans = agent.WaitForSpans(expectedSpanCount, operationName: expectedOperationName);
8482

85-
var settings = VerifyHelper.GetSpanVerifierSettings(binding, enableCallTarget, enableNewWcfInstrumentation);
83+
var settings = VerifyHelper.GetSpanVerifierSettings(binding, enableNewWcfInstrumentation);
8684

8785
await Verifier.Verify(spans, settings)
8886
.UseMethodName("_");

tracer/test/snapshots/WcfTests.__binding=NetTcpBinding_enableCallTarget=True_enableNewWcfInstrumentation=True.verified.txt

Lines changed: 0 additions & 128 deletions
This file was deleted.

tracer/test/snapshots/WcfTests.__binding=WSHttpBinding_enableCallTarget=True_enableNewWcfInstrumentation=False.verified.txt

Lines changed: 0 additions & 146 deletions
This file was deleted.

0 commit comments

Comments
 (0)