Optimization: Make the methodArguments and argsToLoad arguments to WriteBeginMethod constant

Author: zacharycmontoya

tracer/src/Datadog.Trace.ClrProfiler.Native/calltarget_tokens.cpp

@@ -873,8 +873,8 @@ HRESULT CallTargetTokens::ModifyLocalSigAndInitialize(void* rewriterWrapperPtr,
 
 HRESULT CallTargetTokens::WriteBeginMethod(void* rewriterWrapperPtr, mdTypeRef integrationTypeRef,
                                            const TypeInfo* currentType,
-                                           std::vector<FunctionMethodArgument>& methodArguments,
-                                           std::vector<USHORT>& argsToLoad, ILInstr** instruction)
+                                           const std::vector<FunctionMethodArgument>& methodArguments,
+                                           const std::vector<USHORT>& argsToLoad, ILInstr** instruction)
 {
     auto hr = EnsureBaseCalltargetTokens();
     if (FAILED(hr))

tracer/src/Datadog.Trace.ClrProfiler.Native/calltarget_tokens.h

@@ -86,7 +86,7 @@ class CallTargetTokens
                                         mdToken* callTargetReturnToken, ILInstr** firstInstruction);
 
     HRESULT WriteBeginMethod(void* rewriterWrapperPtr, mdTypeRef integrationTypeRef, const TypeInfo* currentType,
-                             std::vector<FunctionMethodArgument>& methodArguments, std::vector<USHORT>& argsToLoad,
+                             const std::vector<FunctionMethodArgument>& methodArguments, const std::vector<USHORT>& argsToLoad,
                              ILInstr** instruction);
 
     HRESULT WriteEndVoidReturnMemberRef(void* rewriterWrapperPtr, mdTypeRef integrationTypeRef,