Remove retry on flush failure

Author: bmermet

src/Datadog.Tracer.Tests/ApiTests.cs

@@ -26,8 +26,6 @@ protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage reques
 
     public class ApiTests
     {
-        private const int _retries = 2;
-
         [Fact]
         public async Task SendServiceAsync_200OK_AllGood()
         {
@@ -44,7 +42,7 @@ public async Task SendServiceAsync_200OK_AllGood()
         }
 
         [Fact]
-        public async Task SendServiceAsync_500_Retry()
+        public async Task SendServiceAsync_500_ErrorIsCaught()
         {
             var response = new HttpResponseMessage
             {
@@ -55,7 +53,8 @@ public async Task SendServiceAsync_500_Retry()
 
             await api.SendServiceAsync(new ServiceInfo());
 
-            Assert.Equal(1 + _retries, handler.RequestsCount);
+            Assert.Equal(1, handler.RequestsCount);
+            // TODO:bertrand check that it's properly logged
         }
     }
 }

src/Datadog.Tracer/Api.cs

@@ -56,29 +56,15 @@ public Api(Uri baseEndpoint, DelegatingHandler delegatingHandler = null)
 
         private async Task SendAsync<T>(T value, Uri endpoint)
         {
-            const int retries = 2;
-            for (int i = 0; i < retries + 1; i++)
+            try
             {
-                try
-                {
-                    var content = new MsgPackContent<T>(value, _serializationContext);
-                    var response = await _client.PostAsync(endpoint, content);
-                    if(response.StatusCode == HttpStatusCode.OK)
-                    {
-                        return;
-                    }
-                    if((int)response.StatusCode >= 400 && (int)response.StatusCode < 500)
-                    {
-                        // TODO:bertrand log
-                        return;
-                    }
-                    throw new HttpRequestException($"The request to {endpoint} failed with status {response.StatusCode}");
-                }
-                catch
-                {
-                    // TODO:bertrand Log
-                }
-                await Task.Delay(TimeSpan.FromSeconds(1));
+                var content = new MsgPackContent<T>(value, _serializationContext);
+                var response = await _client.PostAsync(endpoint, content);
+                response.EnsureSuccessStatusCode();
+            }
+            catch
+            {
+                // TODO:bertrand log
             }
         }