Skip to content

Commit 662b63f

Browse files
author
Brian Devins-Suresh
committed
Add muzzle check to other instrumentation classes
1 parent 38c8b7b commit 662b63f

File tree

5 files changed

+24
-16
lines changed

5 files changed

+24
-16
lines changed

dd-java-agent/instrumentation/vertx-web-4.0/src/main/java/datadog/trace/instrumentation/vertx_4_0/server/HttpServerResponseEndHandlerInstrumentation.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
import com.google.auto.service.AutoService;
99
import datadog.trace.agent.tooling.Instrumenter;
10+
import datadog.trace.agent.tooling.muzzle.Reference;
1011

1112
@AutoService(Instrumenter.class)
1213
public class HttpServerResponseEndHandlerInstrumentation extends Instrumenter.Tracing
@@ -15,6 +16,11 @@ public HttpServerResponseEndHandlerInstrumentation() {
1516
super("vertx", "vertx-4.0");
1617
}
1718

19+
@Override
20+
public Reference[] additionalMuzzleReferences() {
21+
return new Reference[] {VertxVersionMatcher.HTTP_1X_SERVER_RESPONSE};
22+
}
23+
1824
@Override
1925
public String[] helperClassNames() {
2026
return new String[] {

dd-java-agent/instrumentation/vertx-web-4.0/src/main/java/datadog/trace/instrumentation/vertx_4_0/server/RouteHandlerInstrumentation.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
import com.google.auto.service.AutoService;
99
import datadog.trace.agent.tooling.Instrumenter;
10+
import datadog.trace.agent.tooling.muzzle.Reference;
1011

1112
@AutoService(Instrumenter.class)
1213
public class RouteHandlerInstrumentation extends Instrumenter.Tracing
@@ -15,6 +16,11 @@ public RouteHandlerInstrumentation() {
1516
super("vertx", "vertx-4.0");
1617
}
1718

19+
@Override
20+
public Reference[] additionalMuzzleReferences() {
21+
return new Reference[] {VertxVersionMatcher.HTTP_1X_SERVER_RESPONSE};
22+
}
23+
1824
@Override
1925
public String[] helperClassNames() {
2026
return new String[] {

dd-java-agent/instrumentation/vertx-web-4.0/src/main/java/datadog/trace/instrumentation/vertx_4_0/server/RouteImplInstrumentation.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@
88

99
import com.google.auto.service.AutoService;
1010
import datadog.trace.agent.tooling.Instrumenter;
11-
import datadog.trace.agent.tooling.muzzle.IReferenceMatcher;
12-
import datadog.trace.agent.tooling.muzzle.ReferenceMatcher;
11+
import datadog.trace.agent.tooling.muzzle.Reference;
1312

1413
@AutoService(Instrumenter.class)
1514
public class RouteImplInstrumentation extends Instrumenter.AppSec
@@ -19,9 +18,9 @@ public RouteImplInstrumentation() {
1918
super("vertx", "vertx-4.0");
2019
}
2120

22-
private IReferenceMatcher postProcessReferenceMatcher(final ReferenceMatcher origMatcher) {
23-
return new IReferenceMatcher.ConjunctionReferenceMatcher(
24-
origMatcher, VertxVersionMatcher.INSTANCE);
21+
@Override
22+
public Reference[] additionalMuzzleReferences() {
23+
return new Reference[] {VertxVersionMatcher.HTTP_1X_SERVER_RESPONSE};
2524
}
2625

2726
@Override

dd-java-agent/instrumentation/vertx-web-4.0/src/main/java/datadog/trace/instrumentation/vertx_4_0/server/RoutingContextImplInstrumentation.java

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@
66

77
import com.google.auto.service.AutoService;
88
import datadog.trace.agent.tooling.Instrumenter;
9-
import datadog.trace.agent.tooling.muzzle.IReferenceMatcher;
10-
import datadog.trace.agent.tooling.muzzle.ReferenceMatcher;
9+
import datadog.trace.agent.tooling.muzzle.Reference;
1110

1211
@AutoService(Instrumenter.class)
1312
public class RoutingContextImplInstrumentation extends Instrumenter.AppSec
@@ -18,13 +17,13 @@ public RoutingContextImplInstrumentation() {
1817
}
1918

2019
@Override
21-
public String instrumentedType() {
22-
return "io.vertx.ext.web.impl.RoutingContextImpl";
20+
public Reference[] additionalMuzzleReferences() {
21+
return new Reference[] {VertxVersionMatcher.HTTP_1X_SERVER_RESPONSE};
2322
}
2423

25-
private IReferenceMatcher postProcessReferenceMatcher(final ReferenceMatcher origMatcher) {
26-
return new IReferenceMatcher.ConjunctionReferenceMatcher(
27-
origMatcher, VertxVersionMatcher.INSTANCE);
24+
@Override
25+
public String instrumentedType() {
26+
return "io.vertx.ext.web.impl.RoutingContextImpl";
2827
}
2928

3029
@Override
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
package datadog.trace.instrumentation.vertx_4_0.server;
22

33
import datadog.trace.agent.tooling.muzzle.Reference;
4-
import datadog.trace.agent.tooling.muzzle.ReferenceMatcher;
54

65
// checks for vertx > 4
76
public class VertxVersionMatcher {
87
// added in 4.0
9-
static final ReferenceMatcher INSTANCE =
10-
new ReferenceMatcher(
11-
new Reference.Builder("io.vertx.core.http.impl.Http1xServerResponse").build());
8+
static final Reference HTTP_1X_SERVER_RESPONSE =
9+
new Reference.Builder("io.vertx.core.http.impl.Http1xServerResponse").build();
1210
}

0 commit comments

Comments
 (0)