Skip to content

Commit 6e62e42

Browse files
committed
Add entrypoint type to process tags
1 parent 81c468a commit 6e62e42

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

internal-api/src/main/java/datadog/trace/api/ProcessTags.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,12 @@ private static void fillBaseTags(Map<String, String> tags) {
6868
CapturedEnvironment.get().getProcessInfo();
6969
if (processInfo.mainClass != null) {
7070
tags.put("entrypoint.name", processInfo.mainClass);
71+
tags.put("entrypoint.type", "class");
7172
}
7273
if (processInfo.jarFile != null) {
7374
final String jarName = processInfo.jarFile.getName();
7475
tags.put("entrypoint.name", jarName.substring(0, jarName.length() - 4)); // strip .jar
76+
tags.put("entrypoint.type", "jar");
7577
insertLastPathSegmentIfPresent(tags, processInfo.jarFile.getParent(), "entrypoint.basedir");
7678
}
7779

internal-api/src/test/groovy/datadog/trace/api/ProcessTagsForkedTest.groovy

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ class ProcessTagsForkedTest extends DDSpecification {
3030
tags =~ expected
3131
where:
3232
jar | cls | expected
33-
Paths.get("my test", "my.jar").toFile() | null | "entrypoint.basedir:my_test,entrypoint.name:my,entrypoint.workdir:[^,]+"
34-
Paths.get("my.jar").toFile() | null | "entrypoint.name:my,entrypoint.workdir:[^,]+"
35-
null | "com.test.Main" | "entrypoint.name:com.test.main,entrypoint.workdir:[^,]+"
33+
Paths.get("my test", "my.jar").toFile() | null | "entrypoint.basedir:my_test,entrypoint.name:my,entrypoint.type:jar,entrypoint.workdir:[^,]+"
34+
Paths.get("my.jar").toFile() | null | "entrypoint.name:my,entrypoint.type:jar,entrypoint.workdir:[^,]+"
35+
null | "com.test.Main" | "entrypoint.name:com.test.main,entrypoint.type:class,entrypoint.workdir:[^,]+"
3636
null | null | "entrypoint.workdir:[^,]+"
3737
}
3838

@@ -56,9 +56,9 @@ class ProcessTagsForkedTest extends DDSpecification {
5656
System.clearProperty("jboss.server.name")
5757
where:
5858
jbossHome | mode | serverName | expected
59-
"/opt/jboss/myserver" | "[Standalone]" | "standalone" | "entrypoint.basedir:somewhere,entrypoint.name:jboss-modules,entrypoint.workdir:.+,jboss.home:myserver,jboss.mode:standalone,server.name:standalone"
60-
"/opt/jboss/myserver" | "[server1:12345]" | "server1" | "entrypoint.basedir:somewhere,entrypoint.name:jboss-modules,entrypoint.workdir:.+,jboss.home:myserver,jboss.mode:domain,server.name:server1"
61-
null | "[Standalone]" | "standalone" | "entrypoint.basedir:somewhere,entrypoint.name:jboss-modules,entrypoint.workdir:[^,]+" // don't expect jboss tags since home is missing
59+
"/opt/jboss/myserver" | "[Standalone]" | "standalone" | "entrypoint.basedir:somewhere,entrypoint.name:jboss-modules,entrypoint.type:jar,entrypoint.workdir:.+,jboss.home:myserver,jboss.mode:standalone,server.name:standalone"
60+
"/opt/jboss/myserver" | "[server1:12345]" | "server1" | "entrypoint.basedir:somewhere,entrypoint.name:jboss-modules,entrypoint.type:jar,entrypoint.workdir:.+,jboss.home:myserver,jboss.mode:domain,server.name:server1"
61+
null | "[Standalone]" | "standalone" | "entrypoint.basedir:somewhere,entrypoint.name:jboss-modules,entrypoint.type:jar,entrypoint.workdir:[^,]+" // don't expect jboss tags since home is missing
6262
}
6363

6464
def 'should not calculate process tags by default'() {

0 commit comments

Comments
 (0)