Skip to content

Commit 70b5aa2

Browse files
authored
Merge branch 'master' into andrea.marziali/reactor-netty-ws
2 parents 8448b8b + 2dab68d commit 70b5aa2

File tree

7 files changed

+8
-23
lines changed

7 files changed

+8
-23
lines changed

dd-java-agent/instrumentation/kotlin-coroutines/src/test/groovy/KotlinCoroutineInstrumentationTest.groovy

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
import datadog.trace.core.DDSpan
22
import datadog.trace.instrumentation.kotlin.coroutines.AbstractKotlinCoroutineInstrumentationTest
3+
import kotlin.OptIn
34
import kotlinx.coroutines.CoroutineDispatcher
5+
import kotlinx.coroutines.ExperimentalCoroutinesApi
46

7+
@OptIn(markerClass = ExperimentalCoroutinesApi)
58
class KotlinCoroutineInstrumentationTest extends AbstractKotlinCoroutineInstrumentationTest<KotlinCoroutineTests> {
69

710
@Override

dd-java-agent/instrumentation/kotlin-coroutines/src/test/kotlin/KotlinCoroutineTests.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,13 @@ import datadog.trace.bootstrap.instrumentation.api.AgentTracer.get
33
import datadog.trace.instrumentation.kotlin.coroutines.CoreKotlinCoroutineTests
44
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings
55
import kotlinx.coroutines.CoroutineDispatcher
6+
import kotlinx.coroutines.ExperimentalCoroutinesApi
67
import kotlinx.coroutines.channels.actor
78
import kotlinx.coroutines.channels.consumeEach
89
import kotlinx.coroutines.channels.produce
910
import kotlinx.coroutines.channels.toChannel
1011

12+
@OptIn(ExperimentalCoroutinesApi::class)
1113
@SuppressFBWarnings("NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE")
1214
class KotlinCoroutineTests(dispatcher: CoroutineDispatcher) : CoreKotlinCoroutineTests(dispatcher) {
1315

dd-java-agent/instrumentation/liberty-20/src/main/java/datadog/trace/instrumentation/liberty20/LibertyDecorator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ public AgentSpan onResponseStatus(AgentSpan span, int status) {
100100
// we may have the status during response blocking, but in that case
101101
// the status code is not propagated to the servlet layer
102102
if (currentStatus == null || !span.isError()) {
103-
span.setHttpStatusCode(status);
103+
super.onResponseStatus(span, status);
104104
}
105105
return span;
106106
}

dd-java-agent/instrumentation/liberty-20/src/test/groovy/datadog/trace/instrumentation/liberty20/Liberty20Test.groovy

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -127,15 +127,6 @@ abstract class Liberty20Test extends HttpServerTest<Server> {
127127
true
128128
}
129129

130-
@Override
131-
String expectedResourceName(ServerEndpoint endpoint, String method, URI address) {
132-
if (endpoint.path == '/not-found') {
133-
'GET /testapp/not-found'
134-
} else {
135-
super.expectedResourceName(endpoint, method, address)
136-
}
137-
}
138-
139130
def 'test blocking on response with commit during the response'() {
140131
setup:
141132
assumeTrue(testBlockingOnResponse())

dd-java-agent/instrumentation/liberty-23/src/main/java/datadog/trace/instrumentation/liberty23/LibertyDecorator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ public AgentSpan onResponseStatus(AgentSpan span, int status) {
100100
// we may have the status during response blocking, but in that case
101101
// the status code is not propagated to the servlet layer
102102
if (currentStatus == null || !span.isError()) {
103-
span.setHttpStatusCode(status);
103+
super.onResponseStatus(span, status);
104104
}
105105
return span;
106106
}

dd-java-agent/instrumentation/liberty-23/src/test/groovy/datadog/trace/instrumentation/liberty23/Liberty23Test.groovy

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -117,15 +117,6 @@ abstract class Liberty23Test extends HttpServerTest<Server> {
117117
true
118118
}
119119

120-
@Override
121-
String expectedResourceName(ServerEndpoint endpoint, String method, URI address) {
122-
if (endpoint.path == '/not-found') {
123-
'GET /testapp/not-found'
124-
} else {
125-
super.expectedResourceName(endpoint, method, address)
126-
}
127-
}
128-
129120
def 'test blocking on response with commit during the response'() {
130121
setup:
131122
assumeTrue(testBlockingOnResponse())

gradle/java_no_deps.gradle

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -228,9 +228,7 @@ project.afterEvaluate {
228228
if (project.plugins.hasPlugin('kotlin')) {
229229
['compileKotlin', 'compileTestKotlin'].each { type ->
230230
tasks.named(type).configure {
231-
kotlinOptions {
232-
freeCompilerArgs += '-Xmx256m'
233-
}
231+
kotlinDaemonJvmArguments = ["-Xmx256m", "-XX:+UseParallelGC"]
234232
}
235233
}
236234
}

0 commit comments

Comments
 (0)