Making members static final to avoid repeated work & allocation

Author: dougqh

dd-trace-core/src/main/java/datadog/trace/common/writer/RemoteMapper.java

@@ -14,21 +14,21 @@ public interface RemoteMapper extends Mapper<List<? extends CoreSpan<?>>> {
 
   RemoteMapper NO_OP = new NoopRemoteMapper();
 
-  byte[] RUNTIME_ID = DDTags.RUNTIME_ID_TAG.getBytes(UTF_8);
-  byte[] LANGUAGE = DDTags.LANGUAGE_TAG_KEY.getBytes(UTF_8);
-
-  byte[] SERVICE = "service".getBytes(UTF_8);
-  byte[] NAME = "name".getBytes(UTF_8);
-  byte[] RESOURCE = "resource".getBytes(UTF_8);
-  byte[] TRACE_ID = "trace_id".getBytes(UTF_8);
-  byte[] SPAN_ID = "span_id".getBytes(UTF_8);
-  byte[] PARENT_ID = "parent_id".getBytes(UTF_8);
-  byte[] START = "start".getBytes(UTF_8);
-  byte[] DURATION = "duration".getBytes(UTF_8);
-  byte[] TYPE = "type".getBytes(UTF_8);
-  byte[] ERROR = "error".getBytes(UTF_8);
-  byte[] METRICS = "metrics".getBytes(UTF_8);
-  byte[] META = "meta".getBytes(UTF_8);
+  static final byte[] RUNTIME_ID = DDTags.RUNTIME_ID_TAG.getBytes(UTF_8);
+  static final byte[] LANGUAGE = DDTags.LANGUAGE_TAG_KEY.getBytes(UTF_8);
+
+  static final byte[] SERVICE = "service".getBytes(UTF_8);
+  static final byte[] NAME = "name".getBytes(UTF_8);
+  static final byte[] RESOURCE = "resource".getBytes(UTF_8);
+  static final byte[] TRACE_ID = "trace_id".getBytes(UTF_8);
+  static final byte[] SPAN_ID = "span_id".getBytes(UTF_8);
+  static final byte[] PARENT_ID = "parent_id".getBytes(UTF_8);
+  static final byte[] START = "start".getBytes(UTF_8);
+  static final byte[] DURATION = "duration".getBytes(UTF_8);
+  static final byte[] TYPE = "type".getBytes(UTF_8);
+  static final byte[] ERROR = "error".getBytes(UTF_8);
+  static final byte[] METRICS = "metrics".getBytes(UTF_8);
+  static final byte[] META = "meta".getBytes(UTF_8);
 
   UTF8BytesString HTTP_STATUS = UTF8BytesString.create(Tags.HTTP_STATUS);
 

dd-trace-core/src/main/java/datadog/trace/common/writer/ddagent/TraceMapper.java

@@ -6,11 +6,10 @@
 import datadog.trace.core.DDSpanContext;
 
 public interface TraceMapper extends RemoteMapper {
-
-  UTF8BytesString THREAD_NAME = UTF8BytesString.create(DDTags.THREAD_NAME);
-  UTF8BytesString THREAD_ID = UTF8BytesString.create(DDTags.THREAD_ID);
-  UTF8BytesString SAMPLING_PRIORITY_KEY =
+  static final UTF8BytesString THREAD_NAME = UTF8BytesString.create(DDTags.THREAD_NAME);
+  static final UTF8BytesString THREAD_ID = UTF8BytesString.create(DDTags.THREAD_ID);
+  static final UTF8BytesString SAMPLING_PRIORITY_KEY =
       UTF8BytesString.create(DDSpanContext.PRIORITY_SAMPLING_KEY);
-  UTF8BytesString ORIGIN_KEY = UTF8BytesString.create(DDTags.ORIGIN_KEY);
-  UTF8BytesString PROCESS_TAGS_KEY = UTF8BytesString.create(DDTags.PROCESS_TAGS);
+  static final UTF8BytesString ORIGIN_KEY = UTF8BytesString.create(DDTags.ORIGIN_KEY);
+  static final UTF8BytesString PROCESS_TAGS_KEY = UTF8BytesString.create(DDTags.PROCESS_TAGS);
 }