Skip to content

Commit d73f349

Browse files
committed
feat(aws): Refactor AWS instrumentation around Context
1 parent 11d43a3 commit d73f349

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

dd-java-agent/instrumentation/aws-java-sqs-1.0/src/main/java/datadog/trace/instrumentation/aws/v1/sqs/SqsClientInstrumentation.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,7 @@ public String[] helperClassNames() {
4646
@Override
4747
public Map<String, String> contextStore() {
4848
return Collections.singletonMap(
49-
"com.amazonaws.AmazonWebServiceRequest",
50-
"datadog.trace.bootstrap.instrumentation.api.AgentSpan");
49+
"com.amazonaws.AmazonWebServiceRequest", "datadog.context.Context");
5150
}
5251

5352
public static class HandlerChainAdvice {
@@ -62,8 +61,7 @@ public static void addHandler(@Advice.Return final List<RequestHandler2> handler
6261
handlers.add(
6362
new SqsInterceptor(
6463
InstrumentationContext.get(
65-
"com.amazonaws.AmazonWebServiceRequest",
66-
"datadog.trace.bootstrap.instrumentation.api.AgentSpan")));
64+
"com.amazonaws.AmazonWebServiceRequest", "datadog.context.Context")));
6765
}
6866
}
6967
}

dd-java-agent/instrumentation/aws-java-sqs-1.0/src/main/java/datadog/trace/instrumentation/aws/v1/sqs/SqsInterceptor.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@
2929

3030
public class SqsInterceptor extends RequestHandler2 {
3131

32-
private final ContextStore<AmazonWebServiceRequest, AgentSpan> contextStore;
32+
private final ContextStore<AmazonWebServiceRequest, Context> contextStore;
3333

34-
public SqsInterceptor(ContextStore<AmazonWebServiceRequest, AgentSpan> contextStore) {
34+
public SqsInterceptor(ContextStore<AmazonWebServiceRequest, Context> contextStore) {
3535
this.contextStore = contextStore;
3636
}
3737

@@ -89,6 +89,7 @@ private AgentSpan newSpan(AmazonWebServiceRequest request) {
8989
final AgentSpan span = startSpan("sqs", "aws.sqs.send");
9090
// pass the span to TracingRequestHandler in the sdk instrumentation where it'll be enriched &
9191
// activated
92+
// TODO If DSM is enabled, add DSM context here too
9293
contextStore.put(request, span);
9394
return span;
9495
}

0 commit comments

Comments
 (0)