Skip to content

Commit 36dcd9f

Browse files
authored
ci(appsec): update flaky test (#12855)
the `test_load_testing_appsec_1click_and_ip_blocking_gunicorn_block_and_kill_child_worker` test has this decorator: ``` @flaky(until=1742580778, reason="_request_403 is flaky, figure out the error") ``` and its failing today because `time() > 1742580778` We need to investigate that error. Removing `flaky`, updating to `skip` and link this problem to task APPSEC-57052 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
1 parent 5c8fb46 commit 36dcd9f

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

tests/appsec/integrations/flask_tests/test_flask_remoteconfig.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
from tests.appsec.integrations.flask_tests.utils import _PORT
1818
from tests.appsec.integrations.flask_tests.utils import _multi_requests
1919
from tests.appsec.integrations.flask_tests.utils import _request_200
20-
from tests.utils import flaky
2120

2221

2322
def _get_agent_client():
@@ -240,7 +239,7 @@ def test_load_testing_appsec_ip_blocking_gunicorn_block_and_kill_child_worker():
240239
_request_200(gunicorn_client)
241240

242241

243-
@flaky(until=1742580778, reason="_request_403 is flaky, figure out the error")
242+
@pytest.mark.skip(reason="_request_403 is flaky, figure out the error. APPSEC-57052")
244243
def test_load_testing_appsec_1click_and_ip_blocking_gunicorn_block_and_kill_child_worker():
245244
token = "test_load_testing_appsec_1click_and_ip_blocking_gunicorn_block_and_kill_child_worker_{}".format(
246245
str(uuid.uuid4())

0 commit comments

Comments
 (0)