chore: remove logic that uses import importlib_metadata (#13809)

Remove importlib_metadata dependency since it is no longer needed.
Support for Python 3.7 has been dropped, and dd-trace-py now requires
Python 3.8 or later, which includes importlib.metadata in the standard
library.


## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

---------

Co-authored-by: Munir Abdinur <munir_abdinur@hotmail.com>
Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com>

Author: chojomok

ddtrace/contrib/internal/elasticsearch/patch.py

@@ -1,4 +1,6 @@
 from importlib import import_module
+from importlib.metadata import PackageNotFoundError
+from importlib.metadata import version as get_package_version
 from typing import Dict
 from urllib import parse
 
@@ -23,14 +25,6 @@
 from ddtrace.trace import Pin
 
 
-try:
-    from importlib.metadata import PackageNotFoundError
-    from importlib.metadata import version as get_package_version
-except ImportError:
-    from importlib_metadata import PackageNotFoundError
-    from importlib_metadata import version as get_package_version
-
-
 log = get_logger(__name__)
 
 config._add(

ddtrace/contrib/internal/pyramid/patch.py

@@ -24,12 +24,8 @@
 DD_PATCH = "_datadog_patch"
 
 
-def get_version():
-    # type: () -> str
-    try:
-        import importlib.metadata as importlib_metadata
-    except ImportError:
-        import importlib_metadata  # type: ignore[no-redef]
+def get_version() -> str:
+    import importlib.metadata as importlib_metadata
 
     return str(importlib_metadata.version(pyramid.__package__))
 

ddtrace/contrib/internal/pytest_bdd/patch.py

@@ -2,12 +2,8 @@
 
 
 # ddtrace/_monkey.py expects all integrations to define get_version in <integration>/patch.py file
-def get_version():
-    # type: () -> str
-    try:
-        import importlib.metadata as importlib_metadata
-    except ImportError:
-        import importlib_metadata  # type: ignore[no-redef]
+def get_version() -> str:
+    import importlib.metadata as importlib_metadata
 
     return str(importlib_metadata.version("pytest-bdd"))
 

ddtrace/internal/gitmetadata.py

@@ -60,8 +60,7 @@ def _get_tags_from_env():
     return filtered_git_url, commit_sha, main_package
 
 
-def _get_tags_from_package(main_package):
-    # type: (str) -> typing.Tuple[str, str]
+def _get_tags_from_package(main_package: str) -> typing.Tuple[str, str]:
     """
     Extracts git metadata from python package's medatada field Project-URL:
     e.g: Project-URL: source_code_link, https://github.com/user/repo#gitcommitsha&someoptions
@@ -70,10 +69,7 @@ def _get_tags_from_package(main_package):
     if not main_package:
         return "", ""
     try:
-        try:
-            import importlib.metadata as importlib_metadata
-        except ImportError:
-            import importlib_metadata  # type: ignore[no-redef]
+        import importlib.metadata as importlib_metadata
 
         source_code_link = ""
         for val in importlib_metadata.metadata(main_package).get_all("Project-URL") or []:

ddtrace/internal/packages.py

@@ -25,10 +25,7 @@
 @callonce
 def get_distributions() -> t.Mapping[str, str]:
     """returns the mapping from distribution name to version for all distributions in a python path"""
-    try:
-        import importlib.metadata as importlib_metadata
-    except ImportError:
-        import importlib_metadata  # type: ignore[no-redef]
+    import importlib.metadata as importlib_metadata
 
     pkgs = {}
     for dist in importlib_metadata.distributions():
@@ -47,10 +44,7 @@ def get_package_distributions() -> t.Mapping[str, t.List[str]]:
     """a mapping of importable package names to their distribution name(s)"""
     global _PACKAGE_DISTRIBUTIONS
     if _PACKAGE_DISTRIBUTIONS is None:
-        try:
-            import importlib.metadata as importlib_metadata
-        except ImportError:
-            import importlib_metadata  # type: ignore[no-redef]
+        import importlib.metadata as importlib_metadata
 
         # Prefer the official API if available, otherwise fallback to the vendored version
         if hasattr(importlib_metadata, "packages_distributions"):
@@ -89,13 +83,9 @@ def get_module_distribution_versions(module_name: str) -> t.Optional[t.Tuple[str
 
 
 @cached(maxsize=1024)
-def get_version_for_package(name):
-    # type: (str) -> str
+def get_version_for_package(name: str) -> str:
     """returns the version of a package"""
-    try:
-        import importlib.metadata as importlib_metadata
-    except ImportError:
-        import importlib_metadata  # type: ignore[no-redef]
+    import importlib.metadata as importlib_metadata
 
     try:
         return importlib_metadata.version(name)
@@ -149,10 +139,7 @@ def _root_module(path: Path) -> str:
 
 @callonce
 def _package_for_root_module_mapping() -> t.Optional[t.Dict[str, Distribution]]:
-    try:
-        import importlib.metadata as importlib_metadata
-    except ImportError:
-        import importlib_metadata as importlib_metadata  # type: ignore[no-redef]
+    import importlib.metadata as importlib_metadata
 
     namespaces: t.Dict[str, bool] = {}
 
@@ -290,10 +277,7 @@ def _(path: str) -> bool:
 @cached(maxsize=256)
 def is_distribution_available(name: str) -> bool:
     """Determine if a distribution is available in the current environment."""
-    try:
-        import importlib.metadata as importlib_metadata
-    except ImportError:
-        import importlib_metadata  # type: ignore[no-redef]
+    import importlib.metadata as importlib_metadata
 
     try:
         importlib_metadata.distribution(name)
@@ -317,10 +301,7 @@ def _packages_distributions() -> t.Mapping[str, t.List[str]]:
     >>> all(isinstance(dist, collections.abc.Sequence) for dist in pkgs.values())
     True
     """
-    try:
-        import importlib.metadata as importlib_metadata
-    except ImportError:
-        import importlib_metadata  # type: ignore[no-redef]
+    import importlib.metadata as importlib_metadata
 
     pkg_to_dist = collections.defaultdict(list)
     for dist in importlib_metadata.distributions():

ddtrace/internal/products.py

@@ -1,6 +1,7 @@
 import atexit
 from collections import defaultdict
 from collections import deque
+from importlib.metadata import entry_points
 from itertools import chain
 import sys
 import typing as t
@@ -17,10 +18,17 @@
 
 log = get_logger(__name__)
 
-if sys.version_info < (3, 10):
-    from importlib_metadata import entry_points
+
+if sys.version_info >= (3, 10):
+
+    def get_product_entry_points() -> t.List[t.Any]:
+        return list(entry_points(group="ddtrace.products"))
+
 else:
-    from importlib.metadata import entry_points
+
+    def get_product_entry_points() -> t.List[t.Any]:
+        return [ep for _, eps in entry_points().items() for ep in eps if ep.group == "ddtrace.products"]
+
 
 try:
     from typing import Protocol  # noqa:F401
@@ -55,7 +63,7 @@ def __init__(self) -> None:
         self._failed: t.Set[str] = set()
 
     def _load_products(self) -> None:
-        for product_plugin in entry_points(group="ddtrace.products"):
+        for product_plugin in get_product_entry_points():
             name = product_plugin.name
             log.debug("Discovered product plugin '%s'", name)
 

lib-injection/sources/requirements.csv

@@ -4,7 +4,6 @@ bytecode,>=0.15.1,python_version~='3.12.0'
 bytecode,>=0.14.0,python_version~='3.11.0'
 bytecode,>=0.13.0,python_version<'3.11'
 envier,~=0.6.1,
-importlib_metadata,<=6.5.0,python_version<'3.8'
 legacy-cgi,>=2.0.0,python_version>='3.13.0'
 opentelemetry-api,>=1,
 protobuf,>=3,

pyproject.toml

@@ -36,7 +36,6 @@ dependencies = [
     "bytecode>=0.14.0; python_version~='3.11.0'",
     "bytecode>=0.13.0; python_version<'3.11'",
     "envier~=0.6.1",
-    "importlib_metadata<=6.5.0; python_version<'3.8'",
     "legacy-cgi>=2.0.0; python_version>='3.13.0'",
     "opentelemetry-api>=1",
     "protobuf>=3",

requirements.csv

@@ -4,7 +4,6 @@ bytecode,>=0.15.1,python_version~='3.12.0'
 bytecode,>=0.14.0,python_version~='3.11.0'
 bytecode,>=0.13.0,python_version<'3.11'
 envier,~=0.6.1,
-importlib_metadata,<=6.5.0,python_version<'3.8'
 legacy-cgi,>=2.0.0,python_version>='3.13.0'
 opentelemetry-api,>=1,
 protobuf,>=3,

tests/appsec/integrations/flask_tests/utils.py

@@ -1,9 +1,8 @@
+from importlib.metadata import PackageNotFoundError
+from importlib.metadata import version
 from multiprocessing.pool import ThreadPool
 import time
 
-from importlib_metadata import PackageNotFoundError
-from importlib_metadata import version
-
 
 _PORT = 8040
 try: