Skip to content

Commit aa5dce6

Browse files
nsrip-ddbrettlangdon
authored andcommitted
chore: add CPU usage and RSS SLO for macrobenchmarks (#14521)
PR #14205 introduced a significant performance regression, where the profiler created a thread which consumed an entire CPU core spinning in a tight loop. Our macrobenchmarks captured this increased CPU usage, but we didn't have any SLOs defined. This commit adds an SLO for CPU usage based on the typical CPU usage prior to that regression. This commit also adds an RSS SLO, again based on typical usage.
1 parent bd8c376 commit aa5dce6

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

.gitlab/benchmarks/bp-runner.macrobenchmarks.fail-on-breach.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,10 @@ experiments:
4040
thresholds:
4141
- agg_http_req_duration_p50 < 85 ms
4242
- agg_http_req_duration_p95 < 95 ms
43+
- name: normal_operation/tracing-profiling-enabled/python-server-utilization
44+
thresholds:
45+
- cpu_usage_percentage < 220 %
46+
- rss < 1040 MB
4347
- name: high_load/tracing-profiling-enabled
4448
thresholds:
4549
- throughput > 30.0 op/s

0 commit comments

Comments
 (0)