Skip to content

chore(profiling, crashtracking): upgrade libdatadog to v16.0.2 #12263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
taegyunkim wants to merge 12 commits into from
Closed

chore(profiling, crashtracking): upgrade libdatadog to v16.0.2 #12263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
374d8ec
profiling: upgrade libdatadog to v16.0.2
taegyunkim Feb 8, 2025
36ca350
update null mapping
taegyunkim Feb 9, 2025
057daca
set _id fields
taegyunkim Feb 9, 2025
5821cce
test with updated system test
taegyunkim Feb 9, 2025
f5e0a65
update system-tests
taegyunkim Feb 10, 2025
86a1b7f
set refs
taegyunkim Feb 10, 2025
e9db6c8
update
taegyunkim Feb 10, 2025
ef177ec
use branch name
taegyunkim Feb 10, 2025
a6ae3b3
add reno
taegyunkim Feb 10, 2025
427463a
Merge branch 'main' into taegyunkim/upgrade-libdd
taegyunkim Feb 10, 2025
b439902
Discard changes to .github/workflows/system-tests.yml
taegyunkim Feb 10, 2025
67e4de7
Merge branch 'main' into taegyunkim/upgrade-libdd
taegyunkim Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ddtrace/internal/datadog/profiling/cmake/FindLibdatadog.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,17 @@ include(FetchContent)
# Set version if not already set
if(NOT DEFINED TAG_LIBDATADOG)
set(TAG_LIBDATADOG
"v15.0.0"
"v16.0.2"
CACHE STRING "libdatadog github tag")
endif()

if(NOT DEFINED DD_CHECKSUMS)
set(DD_CHECKSUMS
"d5b969b293e5a9e5e36404a553bbafdd55ff6af0b089698bd989a878534df0c7 libdatadog-aarch64-alpine-linux-musl.tar.gz"
"4540ffb8ccb671550a39ba79226117086582c1eaf9714180a9e26bd6bb175860 libdatadog-aarch64-apple-darwin.tar.gz"
"31bceab4f56873b03b3728760d30e3abc493d32ca8fdc9e1f2ec2147ef4d5424 libdatadog-aarch64-unknown-linux-gnu.tar.gz"
"530348c4b02cc7096de2231476ec12db82e2cc6de12a87e5b28af47ea73d4e56 libdatadog-x86_64-alpine-linux-musl.tar.gz"
"5073ffc657bc4698f8bdd4935475734577bfb18c54dcbebc4f7d8c7595626e52 libdatadog-x86_64-unknown-linux-gnu.tar.gz")
"b1e7f971277b5c16339f36f85da38680085974415c31c0414d9b5fed78af6ae4 libdatadog-aarch64-alpine-linux-musl.tar.gz"
"ac9944d030c24f6c570237ade27185e7da0c1018759b14af5783310fb5b75ddc libdatadog-aarch64-apple-darwin.tar.gz"
"88cc2d1f412a1681ae1d1b77ffdb15e0199690324d233b4834ccaccc8437f275 libdatadog-aarch64-unknown-linux-gnu.tar.gz"
"5717af124b2d4187376676f2da7d01e429e481b690eaafe1580181e89b87ee15 libdatadog-x86_64-alpine-linux-musl.tar.gz"
"acf8273bda559700517c6b2de8e6a95b4608ef0200e6c7749507e90b5e75d6cb libdatadog-x86_64-unknown-linux-gnu.tar.gz")
endif()

# Determine platform-specific tarball name in a way that conforms to the libdatadog naming scheme in Github releases
Expand Down
11 changes: 10 additions & 1 deletion ddtrace/internal/datadog/profiling/dd_wrapper/src/sample.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,13 @@ Datadog::Sample::profile_clear_state()
void
Datadog::Sample::push_frame_impl(std::string_view name, std::string_view filename, uint64_t address, int64_t line)
{
static const ddog_prof_Mapping null_mapping = { 0, 0, 0, to_slice(""), to_slice("") };
static const ddog_prof_Mapping null_mapping = { /* memory_start */ 0,
/* memory_limit */ 0,
/* file_offset */ 0,
/* filename */ to_slice(""),
/* filename_id */ ddog_prof_ManagedStringId{ /* value */ 0 },
/* build_id */ to_slice(""),
/* build_id_id */ ddog_prof_ManagedStringId{ /* value */ 0 } };
name = string_storage.insert(name);
filename = string_storage.insert(filename);

Expand All @@ -71,8 +77,11 @@ Datadog::Sample::push_frame_impl(std::string_view name, std::string_view filenam
.mapping = null_mapping, // No support for mappings in Python
.function = {
.name = to_slice(name),
.name_id = ddog_prof_ManagedStringId{ .value = 0 },
.system_name = {}, // No support for system_name in Python
.system_name_id = ddog_prof_ManagedStringId{ .value = 0 },
.filename = to_slice(filename),
.filename_id = ddog_prof_ManagedStringId{ .value = 0 },
.start_line = 0, // We don't know the start_line for the function
},
.address = address,
Expand Down
5 changes: 5 additions & 0 deletions releasenotes/notes/libdd-16.0.2-bc8a1a77c8055974.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
upgrade:
- |
profiling, crashtracking: This upgrades libdatadog to v16.0.2 from v15.0.0

Loading