Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sinatra request path does not include script name #236

Closed
jamiehodge opened this issue Oct 30, 2017 · 1 comment
Closed

Sinatra request path does not include script name #236

jamiehodge opened this issue Oct 30, 2017 · 1 comment
Labels
integrations Involves tracing integrations
Milestone

Comments

@jamiehodge
Copy link
Contributor

jamiehodge commented Oct 30, 2017

The sinatra tracer currently omits the script name from the request path. This means that all subclasses of Sinatra::Base occupy the same path namespace.

Given subclasses Foo and Bar, /foo/:id should not be conflated with /bar/:id

@palazzem palazzem added enhancement integrations Involves tracing integrations labels Jan 10, 2018
@palazzem palazzem added this to the 0.11.0 milestone Jan 10, 2018
@palazzem
Copy link
Contributor

Hey @jamiehodge! we've addressed this issue with the latest beta release (#283 is the reference PR). Closing this issue since it wasn't properly tracked in the PR.

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations
Projects
None yet
Development

No branches or pull requests

2 participants