Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting a custom service name for net/http doesn't work. #407

Closed
undergroundwebdesigns opened this issue Apr 25, 2018 · 3 comments
Closed
Assignees
Labels
bug Involves a bug community Was opened by a community member integrations Involves tracing integrations
Milestone

Comments

@undergroundwebdesigns
Copy link

From my experience and from reading the code, it looks like the service name for the net/http integration is hard-coded to "net/http", which conflicts with the docs that say the default service name is "http" and also that it's configurable with the service_name option.

@delner
Copy link
Contributor

delner commented Apr 25, 2018

Can you provide a code sample that replicates the problem? What version of the library are you using?

@pawelchcki
Copy link
Contributor

@undergroundwebdesigns Thank you for reporting this!

PR #430 addresses both default service name in docs, and ability to override it. It will be included in 0.12.1 release.

@delner delner added bug Involves a bug integrations Involves tracing integrations community Was opened by a community member labels May 24, 2018
@delner
Copy link
Contributor

delner commented Jun 4, 2018

Closing this, since it will be released as a part of 0.12.1. Thanks again for your contribution!

@delner delner closed this as completed Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Involves a bug community Was opened by a community member integrations Involves tracing integrations
Projects
None yet
Development

No branches or pull requests

3 participants