-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NoMethodError: undefined method `status' for #<Array:0x000000116d9758> #419
Comments
@frsantos Thanks for the report. Does your application implement any middleware that might be changing the object passed down the chain? That It's possible this is related to this commit where we now prepend a tracing module (instead of rewriting the method on the class, to avoid conflicts.) Could you narrow down the differences between a successful request and a request that produces this error? Especially as it affects what |
@delner No, we don't implement any middleware . The only difference is the Devise::FailureApp (that inherits from |
We're prepending the patch to I'll dive deeper into this. |
Okay, so this might be a "bug" with Devise. They're doing an override in their From what I can tell, does this because I think maybe the simplest way around this is to add some kind of type-checking in the tracing patch, so that it handles this okay. I think this really should be changed in Devise, though. |
@delner Yes, that fixes it, thanks. 🥇 |
@frsantos Glad to hear! We'll roll this into our next bugfix release. |
Fixed it for me as well |
This has been merged into |
Release |
- backported fix for status being Array into refactored patcher # Conflicts: # lib/ddtrace/contrib/rails/core_extensions.rb
After updating to 0.12.0, I get this exception anytime a user logs in with a wrong password.
The error is in the line
When I inspect the
response
object, I get this array (not aResponse
object):[200, {"X-Frame-Options"=>"SAMEORIGIN", "X-XSS-Protection"=>"1; mode=block", "X-Content-Type-Options"=>"nosniff", "Content-Type"=>"text/html; charset=utf-8"}, #<ActionDispatch::Response::RackBody:0x0000000f1b2c40>]
The text was updated successfully, but these errors were encountered: