Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: for redis cluster, don't report MOVED responses as errors #4296

Open
mbyio opened this issue Jan 16, 2025 · 0 comments
Open

[FEATURE]: for redis cluster, don't report MOVED responses as errors #4296

mbyio opened this issue Jan 16, 2025 · 0 comments
Labels
community Was opened by a community member feature-request A request for a new feature or change to an existing one

Comments

@mbyio
Copy link

mbyio commented Jan 16, 2025

Gem Name

No response

Gem Version(s)

No response

Describe the goal of the feature

Hi! I would love if we could have the option to record MOVED responses as non-errors when tracing a Redis Cluster client. MOVED responses are not really errors, they just mean the cluster client has to retry with a different node. They are more like an HTTP 301 redirect. So, recording them as MOVED messes with our error rate metrics.

Is your feature request related to a problem?

Redis MOVED responses are recorded as errors, which causes incorrect error rate metrics.

Describe alternatives you've considered

It may be possible to fix this with monkey patching, but it is pretty tricky. Also, I think it is behavior a lot of people would want. I noticed that some other integrations also provide ways to customize what is considered an error, and maybe that would be appropriate for redis too.

Additional context

No response

How does Datadog help you?

No response

@mbyio mbyio added community Was opened by a community member feature-request A request for a new feature or change to an existing one labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Was opened by a community member feature-request A request for a new feature or change to an existing one
Projects
None yet
Development

No branches or pull requests

1 participant