Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Shoryuken integration #538

Closed
steveh opened this issue Sep 12, 2018 · 5 comments
Closed

Feature request: Shoryuken integration #538

steveh opened this issue Sep 12, 2018 · 5 comments
Assignees
Labels
community Was opened by a community member feature-request A request for a new feature or change to an existing one
Milestone

Comments

@steveh
Copy link
Contributor

steveh commented Sep 12, 2018

Shoryuken is a Ruby worker for Amazon SQS.

It has middleware based on Sidekiq, with a slightly different signature:

class MyMiddleware
  def call(worker_instance, queue, sqs_msg, body)
    puts 'Before work'
    yield
    puts 'After work'
  end
end

An important thing to note is that Shoryuken can be run in a batch mode, in which case sqs_msg and body will be arrays, see this test for an example.

It uses the AWS SQS API underneath, which is already partially tracked by ddtrace.

@delner
Copy link
Contributor

delner commented Sep 13, 2018

Cool, this is really helpful detail @steveh ! I'm going to add this to our backlog now, so we can get this scheduled. Thanks for bringing this one to our attention!

@delner delner self-assigned this Sep 13, 2018
@delner delner added feature-request A request for a new feature or change to an existing one community Was opened by a community member labels Sep 13, 2018
@kawamanza
Copy link

Hello @delner, I had locally implemented this middleware to allow monitoring on Shoryuken workers recently. It's working fine and I thought about sharing this middleware with the community. Did you start implementing this middleware?

@delner
Copy link
Contributor

delner commented Oct 1, 2018

We have not yet, and would welcome any pull request you'd like to share! I'd be happy to work with you to see if we can get it merged in.

@kawamanza
Copy link

Done ☝️

@delner delner added this to the 0.18.0 milestone Dec 14, 2018
@delner
Copy link
Contributor

delner commented Dec 14, 2018

@steveh @kawamanza we merged #626 which adds support for this. It should roll with the 0.18.0 release. Closing this issue; thank you!

@delner delner closed this as completed Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Was opened by a community member feature-request A request for a new feature or change to an existing one
Projects
None yet
Development

No branches or pull requests

3 participants