Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Expose poll style API for DmaFile #445

Open
waynexia opened this issue Oct 19, 2021 · 1 comment
Open

Proposal: Expose poll style API for DmaFile #445

waynexia opened this issue Oct 19, 2021 · 1 comment

Comments

@waynexia
Copy link
Contributor

This proposes to add some interfaces for DmaFile (and maybe other necessary structures later).

DmaFile's read/write implementations use Source::collect_rw() which relies on poll_fn to convert a poll-based workflow into async fn. IMHO It would also be natural to expose those poll-based APIs alone with async version. This brings a bit more flexibility by providing another way to use DmaFile under the async environment. Otherwise, we need to do a lot of (bad) workarounds to "poll" those read/write tasks.

Please let me know your opinion!

@waynexia
Copy link
Contributor Author

I made a example poll version read_at_aligned in #446, please check it out :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant