Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix library shutdown #117

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Fix library shutdown #117

merged 1 commit into from
Jul 16, 2020

Conversation

blevz
Copy link
Contributor

@blevz blevz commented Jul 14, 2020

  • Make the Telemetry TimerTask a daemon
  • Make the StatsDProcessor Executor use daemon threads

…king the StatsDProcessor use daemon threads in its executor
Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks perfect to me! Thank you so much @blevz! 🙇

@truthbk
Copy link
Member

truthbk commented Jul 16, 2020

I've got to check a couple more things, around the lib, but will shoot for a release today or tomorrow.

Thanks again for your contribution @blevz 🙏

@truthbk truthbk merged commit 56ddb6f into DataDog:master Jul 16, 2020
dbyron0 pushed a commit to locationlabs/java-dogstatsd-client that referenced this pull request Jan 11, 2021
…king the StatsDProcessor use daemon threads in its executor (DataDog#117)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants