Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make environment variable strings public again #132

Merged

Conversation

dbyron0
Copy link
Contributor

@dbyron0 dbyron0 commented Jan 11, 2021

prior to #107 (released in version 2.10.0), they were public.

This was useful at least for some tests we've got. It'd be nice to see them public again.

prior to DataDog#107 (released in version
2.10.0), they were public.
@dbyron0 dbyron0 force-pushed the make_dd_entity_id_env_var_public branch from ae709a2 to a2338d4 Compare January 11, 2021 22:16
Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, there's no harm in doing this. Thank you for the feedback @dbyron0 :)

@truthbk truthbk merged commit c66d62a into DataDog:master Jun 9, 2021
@dbyron0 dbyron0 deleted the make_dd_entity_id_env_var_public branch June 9, 2021 18:48
@dbyron0
Copy link
Contributor Author

dbyron0 commented Jun 9, 2021

Thank you!

@truthbk truthbk added this to the 2.13.0 milestone Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants