Fix unicode length calculations in event strings #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old code calculated the length of header and message body sent to statsd using codepoints instead of raw UTF-8 lengths. The new code now ensures that both of those field lengths are properly calculated using the expected encoding.
sgnn7
force-pushed
the
sgnn7/fix-unicode-event-processing
branch
from
be3c08a
to
d63ac45
Compare
truthbk
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old code calculated the length of header and message body sent to statsd
using codepoints instead of raw byte UTF-8 lengths. The new code now ensures
that both of those field lengths are properly calculated using the
expected encoding.
Fixes: #148