Add support for DD_DOGSTATSD_URL #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, named pipe from the environment would be used even if the application supplies host and port pair explicitly. Make sure the builder uses configuration in this order: 1. explicitly supplied by the application via builder methods 2. auto-detected settings from the environment variables 3. built-in defaults
vickenty
force-pushed
the
vickenty/lookup
branch
from
72c3d18
to
5cdc84d
Compare
Takes precedence over other environment variables and can be used to specify UDP, unix socket and named pipe addresses.
vickenty
force-pushed
the
vickenty/lookup
branch
from
5cdc84d
to
85be52f
Compare
gh123man
reviewed
Mar 9, 2023
| /** | ||
| * Return true if object is a NamedPipeSocketAddress referring to the same path. | ||
| */ | ||
| public boolean equals(Object object) { |
There was a problem hiding this comment.
It is used implicitly in tests when we assertEquals two NamedPipeSocketAddresses
gh123man
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.