-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial UDS stream implementation #228
Conversation
I find it a little strange that none of the gitlab CI appears to have fired. Worthwhile to push an empty commit, or rebase from main, in case gitlab was broken at the branch point of this PR. |
We don't have gitlab CI for this project |
13eb91c
to
aaee24f
Compare
This is similar to DataDog/java-dogstatsd-client#228
src/test/java/com/timgroup/statsd/UnixStreamSocketDummyStatsDServer.java
Show resolved
Hide resolved
I think I addressed everything but give me some time to validate that the tests are not flakky |
src/test/java/com/timgroup/statsd/UnixStreamSocketDummyStatsDServer.java
Outdated
Show resolved
Hide resolved
This is similar to DataDog/java-dogstatsd-client#228
06f8818
to
d50bb85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nits about comments, but otherwise LGTM
This PR adds experimental support for UDS streams, which can be used by using
DD_DOGSTATSD_URL=unixstream:///path/to/dsd.sock
or the following code:Before this transport becomes GA we should revisit the builder to make it easier to use.
The telemetry will behave exactly like the go client with DataDog/datadog-go#290
If
unix://
is used orTransportType.UDS
we still default toSOCK_DGRAM
and do not try to guess the socket type (yet) as this isn't trivial with the current code structure (in particular when we create the client before the socket exists)