[Versioning] Rename datadog-profiling crates (#1325)

Rename ddtelemetry and ddtelemetry-ffi

Fix FFI tests

Try to fix package_ffi_on_windows gitlab job

Rename ddcommon and ddcommon-ffi

windows fix

Fix crashtracker cbindgen.

Merge branch 'igor/versioning/libdd-telemetry' into igor/versioning/libdd-common

fully update the ddcommon and ddcommon-ffi dependencies to reflect the new libdd prefix

Merge remote-tracking branch 'origin/main' into igor/versioning/libdd-common

Add missing version

Rename crashtracker and crashtracker-ffi.

Fix compilation.

Fix build.

Fix lint.

Fix tests.

Fix workflows.

Change libddprog-build branch to execute jobs.

Rename datadog-profiling crates.

Fix build.

Fix lint.

Fix fuzz workflow.

Fix Dockerfile.

Fix LICENSES.

Fix windows release

Merge remote-tracking branch 'origin/main' into julio/versioning/crashtracker

Merge remote-tracking branch 'origin/main' into julio/versioning/crashtracker

Merge branch 'main' into julio/versioning/crashtracker

Restore data-pipeline-ffi feature of datadog-profiling-ffi

Restore data-pipeline-ffi feature of datadog-profiling-ffi

Merge branch 'julio/versioning/crashtracker' into julio/versioning/profiling

Remove package aliases

clean up

Merge remote-tracking branch 'origin/main' into julio/versioning/crashtracker

fix libdd-common-ffi import in libdd-telemetry-ffi

fix formatting

update license file

Merge remote-tracking branch 'origin/main' into julio/versioning/crashtracker

Merge branch 'julio/versioning/crashtracker' into julio/versioning/profiling

Merge remote-tracking branch 'origin/main' into julio/versioning/profiling

Fix test to use profiling-ffi version.

Co-authored-by: ekump <edmund.kump@datadoghq.com>
Co-authored-by: iunanua <igor.unanua@datadoghq.com>
Co-authored-by: julio.gonzalez <julio.gonzalez@datadoghq.com>

Author: 3 people

.github/workflows/fuzz.yml

@@ -7,7 +7,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        directory: [libdd-alloc, datadog-profiling, libdd-common-ffi, libdd-trace-utils]
+        directory: [libdd-alloc, libdd-profiling, libdd-common-ffi, libdd-trace-utils]
     env:
       CARGO_TERM_COLOR: always
     steps:

Cargo.lock

@@ -15,8 +15,8 @@ members = [
   "libdd-library-config-ffi",
   "datadog-live-debugger",
   "datadog-live-debugger-ffi",
-  "datadog-profiling",
-  "datadog-profiling-ffi",
+  "libdd-profiling",
+  "libdd-profiling-ffi",
   "libdd-profiling-protobuf",
   "datadog-profiling-replayer",
   "datadog-remote-config",

Cargo.toml

@@ -1,4 +1,4 @@
-root_name: builder, build_common, tools, libdd-alloc, libdd-crashtracker, libdd-common, libdd-telemetry, libdd-ddsketch, libdd-crashtracker-ffi, libdd-common-ffi, datadog-ffe, datadog-ffe-ffi, datadog-ipc, datadog-ipc-macros, libdd-tinybytes, tarpc, tarpc-plugins, spawn_worker, cc_utils, libdd-library-config, libdd-library-config-ffi, datadog-live-debugger, datadog-live-debugger-ffi, datadog-profiling, libdd-profiling-protobuf, datadog-profiling-ffi, libdd-data-pipeline-ffi, libdd-data-pipeline, libdd-dogstatsd-client, libdd-trace-protobuf, libdd-trace-stats, libdd-trace-utils, libdd-trace-normalization, libdd-log, libdd-ddsketch-ffi, libdd-log-ffi, libdd-telemetry-ffi, symbolizer-ffi, datadog-profiling-replayer, datadog-remote-config, datadog-sidecar, datadog-sidecar-macros, datadog-sidecar-ffi, datadog-trace-obfuscation, datadog-tracer-flare, sidecar_mockgen, test_spawn_from_lib
+root_name: builder, build_common, tools, libdd-alloc, libdd-crashtracker, libdd-common, libdd-telemetry, libdd-ddsketch, libdd-crashtracker-ffi, libdd-common-ffi, datadog-ffe, datadog-ffe-ffi, datadog-ipc, datadog-ipc-macros, libdd-tinybytes, tarpc, tarpc-plugins, spawn_worker, cc_utils, libdd-library-config, libdd-library-config-ffi, datadog-live-debugger, datadog-live-debugger-ffi, libdd-profiling, libdd-profiling-protobuf, libdd-profiling-ffi, libdd-data-pipeline-ffi, libdd-data-pipeline, libdd-dogstatsd-client, libdd-trace-protobuf, libdd-trace-stats, libdd-trace-utils, libdd-trace-normalization, libdd-log, libdd-ddsketch-ffi, libdd-log-ffi, libdd-telemetry-ffi, symbolizer-ffi, datadog-profiling-replayer, datadog-remote-config, datadog-sidecar, datadog-sidecar-macros, datadog-sidecar-ffi, datadog-trace-obfuscation, datadog-tracer-flare, sidecar_mockgen, test_spawn_from_lib
 third_party_libraries:
 - package_name: addr2line
   package_version: 0.24.2

LICENSE-3rdparty.yml

@@ -12,7 +12,7 @@ edition = "2021"
 once_cell = "1.18"
 anyhow = "1.0"
 current_platform = "0.2.0"
-datadog-profiling = { path = "../datadog-profiling" }
+libdd-profiling = { path = "../libdd-profiling" }
 libdd-crashtracker = { path = "../libdd-crashtracker" }
 libdd-common = { path = "../libdd-common" }
 tempfile = "3.3"

bin_tests/Cargo.toml

@@ -21,22 +21,25 @@ use once_cell::sync::OnceCell;
 /// item, or a `cargo run` command to be able to locate artifacts built by cargo from the position
 /// of the current binary.
 
-#[derive(Debug, PartialEq, Eq, Hash, Clone, Copy)]
+#[derive(Debug, Default, PartialEq, Eq, Hash, Clone, Copy)]
 pub enum ArtifactType {
+    #[default]
     ExecutablePackage,
     CDylib,
     Bin,
 }
 
-#[derive(Debug, PartialEq, Eq, Hash, Clone, Copy)]
+#[derive(Debug, Default, PartialEq, Eq, Hash, Clone, Copy)]
 pub enum BuildProfile {
+    #[default]
     Debug,
     Release,
 }
 
-#[derive(Debug, PartialEq, Eq, Hash, Clone)]
+#[derive(Debug, Default, PartialEq, Eq, Hash, Clone)]
 pub struct ArtifactsBuild {
     pub name: String,
+    pub lib_name_override: Option<String>,
     pub artifact_type: ArtifactType,
     pub build_profile: BuildProfile,
     pub triple_target: Option<String>,
@@ -97,13 +100,16 @@ fn inner_build_artifact(c: &ArtifactsBuild) -> anyhow::Result<PathBuf> {
         ArtifactType::ExecutablePackage | ArtifactType::Bin => artifact_path.push(&c.name),
         ArtifactType::CDylib => {
             let name = "lib".to_owned()
-                + &c.name.replace('-', "_")
+                + c.lib_name_override
+                    .as_deref()
+                    .unwrap_or(&c.name.replace('-', "_"))
                 + "."
                 + shared_lib_extension(
                     c.triple_target
                         .as_deref()
                         .unwrap_or(current_platform::CURRENT_PLATFORM),
                 )?;
+            println!("NAME: {}", name);
             artifact_path.push(name);
         }
     };

bin_tests/src/lib.rs

@@ -198,6 +198,7 @@ fn test_crash_tracking_callstack() {
         build_profile: BuildProfile::Debug,
         artifact_type: ArtifactType::Bin,
         triple_target: None,
+        ..Default::default()
     };
 
     let fixtures = setup_test_fixtures(&[&crashtracker_receiver, &crashing_app]);
@@ -1412,12 +1413,14 @@ fn setup_crashtracking_crates(
         build_profile: crash_tracking_receiver_profile,
         artifact_type: ArtifactType::Bin,
         triple_target: None,
+        ..Default::default()
     };
     let crashtracker_receiver = ArtifactsBuild {
         name: "test_crashtracker_receiver".to_owned(),
         build_profile: crash_tracking_receiver_profile,
         artifact_type: ArtifactType::Bin,
         triple_target: None,
+        ..Default::default()
     };
     (crashtracker_bin, crashtracker_receiver)
 }

bin_tests/tests/crashtracker_bin_test.rs

@@ -25,10 +25,12 @@ fn test_the_tests_inner(profile: BuildProfile) {
         build_profile: profile,
         artifact_type: ArtifactType::Bin,
         triple_target: None,
+        ..Default::default()
     };
     let crates = &[
         &ArtifactsBuild {
-            name: "datadog-profiling-ffi".to_owned(),
+            name: "libdd-profiling-ffi".to_owned(),
+            lib_name_override: Some("datadog_profiling_ffi".to_owned()),
             build_profile: profile,
             artifact_type: ArtifactType::CDylib,
             triple_target: None,

bin_tests/tests/test_the_tests.rs

@@ -14,7 +14,7 @@ use std::process::Command;
 use std::rc::Rc;
 use tools::headers::dedup_headers;
 
-const CRATE_FOLDER: &str = "datadog-profiling-ffi";
+const CRATE_FOLDER: &str = "libdd-profiling-ffi";
 
 #[derive(Deserialize)]
 struct CargoFile {