Skip to content

[ruby] Enable IP blocking tests for Ruby #3937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
y9v merged 7 commits into from
Feb 6, 2025
Merged

[ruby] Enable IP blocking tests for Ruby #3937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
76d84b6
Enable IP blocking tests for Ruby
y9v Jan 30, 2025
0790744
Ruby: Set the number of threads to 1 for blocking tests
y9v Feb 3, 2025
1e4fe3c
Enable full user id denylist blocking
y9v Feb 4, 2025
bdc5c9b
Temp: Add sleep before executing ip blocking tests
y9v Feb 4, 2025
d0f1865
Remove sleep
y9v Feb 5, 2025
00e4175
Remove env variable for full denylist blocking test
y9v Feb 5, 2025
f21ed75
Disable full denylist blocking for ruby < 2.11.0-dev
y9v Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions manifests/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ tests/:
test_identify.py:
Test_Basic: v1.0.0
test_ip_blocking_full_denylist.py:
Test_AppSecIPBlockingFullDenylist: missing_feature (Ruby supported denylists of 2500 entries but it fails to block this those 15000)
Test_AppSecIPBlockingFullDenylist: v2.9.0
test_logs.py:
Test_Standardization: missing_feature
Test_StandardizationBlockMode: missing_feature
Expand Down Expand Up @@ -306,7 +306,7 @@ tests/:
Test_ExternalWafRequestsIdentification: v1.22.0
Test_RetainTraces: v0.54.2
test_user_blocking_full_denylist.py:
Test_UserBlocking_FullDenylist: missing_feature (Ruby supported denylists of 2500 entries but it fails to block this those 15000)
Test_UserBlocking_FullDenylist: v2.9.0
test_versions.py:
Test_Events: v0.54.2
debugger/:
Expand Down
2 changes: 1 addition & 1 deletion tests/appsec/test_ip_blocking_full_denylist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
# This product includes software developed at Datadog (https://www.datadoghq.com/).
# Copyright 2021 Datadog, Inc.


from utils import weblog, context, interfaces, rfc, bug, scenarios, missing_feature, features

from .utils import BaseFullDenyListTest
Expand All @@ -27,6 +26,7 @@ def setup_blocked_ips(self):

@missing_feature(weblog_variant="spring-boot" and context.library < "java@0.111.0")
@bug(context.library >= "java@1.22.0" and context.library < "java@1.35.0", reason="APMRP-360")
@bug(context.library < "ruby@2.11.0-dev", reason="APMRP-56691")
def test_blocked_ips(self):
"""Test blocked ips are enforced"""

Expand Down
1 change: 1 addition & 0 deletions tests/appsec/test_user_blocking_full_denylist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ def setup_blocking_test(self):
@bug(context.library < "ruby@1.12.1", reason="APMRP-360")
@bug(context.library >= "java@1.22.0" and context.library < "java@1.35.0", reason="APMRP-360")
@bug(library="java", weblog_variant="spring-boot-payara", reason="APPSEC-56006")
@bug(context.library < "ruby@2.11.0-dev", reason="APMRP-56691")
def test_blocking_test(self):
"""Test with a denylisted user"""

Expand Down