Skip to content

[NodeJS] skip failing baggage tests #4015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ida613 merged 6 commits into from
Feb 6, 2025
Merged

[NodeJS] skip failing baggage tests #4015

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4e13a71
skip failing baggage tests
ida613 Feb 6, 2025
5924827
skip failing tests
ida613 Feb 6, 2025
c18a6ad
add import and fix linter errors
ida613 Feb 6, 2025
859068c
add import
ida613 Feb 6, 2025
52c9215
Merge branch 'main' into ida613/skip-failing-baggage-tests
ida613 Feb 6, 2025
02754ec
fix linter errors
ida613 Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion tests/parametric/test_headers_baggage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from utils._decorators import irrelevant
from utils.parametric.spec.trace import find_only_span
from utils import features, scenarios, context
from utils import features, scenarios, context, missing_feature

from typing import Any
import pytest

Expand Down Expand Up @@ -38,6 +39,7 @@ def test_headers_baggage_default_D001(self, test_agent, test_library):
assert headers["baggage"] == "foo=bar"

@only_baggage_enabled()
@missing_feature(context.library == "nodejs", reason="pausing on this feature to avoid app crashes")
def test_headers_baggage_only_D002(self, test_library):
"""Ensure that only baggage headers are injected when baggage is the only enabled propagation style."""
with test_library:
Expand Down Expand Up @@ -88,6 +90,9 @@ def test_baggage_inject_header_D004(self, test_library):
assert "serverNode=DF%2028" in baggage_items
assert "%22%2C%3B%5C%28%29%2F%3A%3C%3D%3E%3F%40%5B%5D%7B%7D=%22%2C%3B%5C" in baggage_items

@missing_feature(
context.library == "nodejs", reason="`dd_extract_headers_and_make_child_span` does not work with only baggage"
)
def test_baggage_extract_header_D005(self, test_library):
"""Testing baggage header extraction and decoding"""

Expand Down Expand Up @@ -137,6 +142,9 @@ def test_baggage_set_disabled_D007(self, test_library):
headers = test_library.dd_inject_headers(span.span_id)
assert not any("baggage" in item for item in headers)

@missing_feature(
context.library == "nodejs", reason="`dd_extract_headers_and_make_child_span` does not work with only baggage"
)
def test_baggage_get_D008(self, test_library):
"""Testing baggage API get_baggage"""
with test_library.dd_extract_headers_and_make_child_span(
Expand All @@ -149,6 +157,9 @@ def test_baggage_get_D008(self, test_library):
assert span.get_baggage("userId") == "Amélie"
assert span.get_baggage("serverNode") == "DF 28"

@missing_feature(
context.library == "nodejs", reason="`dd_extract_headers_and_make_child_span` does not work with only baggage"
)
def test_baggage_get_all_D009(self, test_library):
"""Testing baggage API get_all_baggage"""
with test_library.dd_extract_headers_and_make_child_span(
Expand Down