Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong default value for datadog_monitor.no_data_timeframe #206

Closed
arbll opened this issue May 16, 2019 · 0 comments · Fixed by #212
Closed

wrong default value for datadog_monitor.no_data_timeframe #206

arbll opened this issue May 16, 2019 · 0 comments · Fixed by #212

Comments

@arbll
Copy link
Member

arbll commented May 16, 2019

Terraform Version

Terraform v0.11.13

Affected Resource(s)

  • datadog_monitor

Terraform Configuration Files

resource "datadog_monitor" "agent_running" {
  name = "${local.prefix} Agent is not running"
  type = "metric alert"
  query = "min(last_1m):min:datadog.agent.running{${local.filters}} by {host} < 1"

  message = <<EOT
${var.alert_handles}
EOT
  notify_no_data = true
}

Expected Behavior

According to the docs the default value for datadog_monitor.no_data_timeframe should be

Default: 2x timeframe for metric alerts, 2 minutes for service checks.

To be honest this default seems randomly chosen and I am not sure if it makes a lot of sense.

Actual Behavior

datadog_monitor.no_data_timeframe is set to 0 by default. This bring the strange side effect that editing a monitor created from terraform with datadog_monitor.no_data_timeframe equal to 0 in the web app will make the UI reset the value to the web app default (10 minutes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant