Make is_admin computed #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
is_adminflag that is going through its deprecation process has a lower precedence than theaccess_roleflag.The is_admin doesn't really get used in the request, but is still returned with a different value depending on what the access_role for that user is set to. For this reason we should make it a Computed value to avoid spurious diffs while users make the transition.
Before this change, if you were using the is_admin config option and had it set to True, you'd get a user that was an admin. If you transition to the access_role flag, and remove the
is_admin, the default was False, and Terraform would attempt to mark this flag as false. Since theaccess_roletakes precedence this led to an untrue diff being shown to the user on each new plan/apply. This removes that diff unless there is an explicit user config change.