Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a mutex to all AWS integration operations that change data to prevent race conditions #254

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Add a mutex to all AWS integration operations that change data to prevent race conditions #254

merged 1 commit into from
Jun 28, 2019

Conversation

bkabrda
Copy link
Contributor

@bkabrda bkabrda commented Jun 28, 2019 •
edited
Loading

Fixes #132.

As confirmed by DD's team responsible for this part of API, operations on AWS integration on a single account should be serialized.

@ghost ghost added the size/XS label Jun 28, 2019
gzussa
gzussa approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems LGTM. Mutex all the things

@bkabrda
Copy link
Contributor Author

bkabrda commented Jun 28, 2019

Thanks for the review. Merging.

@bkabrda bkabrda merged commit fe1f869 into DataDog:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzussa gzussa gzussa approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datadog_integration_aws fails with count
2 participants
@bkabrda @gzussa