Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing 'exists' methods to PD integration and PD service objects #324

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Add missing 'exists' methods to PD integration and PD service objects #324

merged 1 commit into from
Sep 26, 2019

Conversation

bkabrda
Copy link
Contributor

@bkabrda bkabrda commented Sep 25, 2019

Without this, people would experience TF error out if the integration was manually deactivated outside TF (the Read functions would fail with 404 and TF wouldn't recover from that).

@ghost ghost added the size/S label Sep 25, 2019
Copy link
Contributor

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, looks good to me!

@bkabrda
Copy link
Contributor Author

bkabrda commented Sep 26, 2019

Thanks for the review! Merging.

@bkabrda bkabrda merged commit 035a34c into DataDog:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants