Ignore the change of no_data_timeframe if notify_no_data is false #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will resolve https://github.com/terraform-providers/terraform-provider-datadog/issues/383. Datadog seemed the response of monitors recently changed. For example, if I execute the following script: ```sh for monitor_id in $OLD_MONITOR_ID $RECENT_CHANGED_MONITOR_ID; do curl -s -X GET \ -H "DD-API-KEY: ${DATADOG_API_KEY}" \ -H "DD-APPLICATION-KEY: ${DATADOG_APP_KEY}" \ -d "group_states=all" \ "https://api.datadoghq.com/api/v1/monitor/${monitor_id}" | \ jq '{modified, options: .options | {notify_no_data, no_data_timeframe}}' done ``` The output is like below: ``` { "modified": "2019-09-17T08:08:32.094503+00:00", "options": { "notify_no_data": false, "no_data_timeframe": 10 } } { "modified": "2020-01-07T14:06:55.889061+00:00", "options": { "notify_no_data": false, "no_data_timeframe": null } } ```
ghost
added
the
platinummonkey
approved these changes
Jan 15, 2020
|
Hey folks, is there a release planned with this change soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will resolve https://github.com/terraform-providers/terraform-provider-datadog/issues/383.
Datadog seems to have changed the response of monitors recently modified and the response no longer includes "no_data_timeframe" if "notify_no_data" is false.
For example, if I execute the following script:
The output is like below: