Add template_variable_presets to datadog_dashboard #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
bkabrda
suggested changes
Feb 7, 2020
There was a problem hiding this comment.
Hey, thanks a lot for sending this PR! The code looks good and works like a charm. I left a small note inline to rebase on top of latest master. I'd also like to ask you to update the docs in website/docs/r/dashboard.html.markdown to provide an example and docs of this feature (make website and make website-test will help you see if your changes look fine). Thanks!
go.mod
Outdated
| @@ -6,7 +6,7 @@ require ( | |||
| github.com/hashicorp/go-cleanhttp v0.5.0 | |||
| github.com/hashicorp/terraform v0.12.5 | |||
| github.com/kr/pretty v0.1.0 | |||
| github.com/zorkian/go-datadog-api v2.25.0+incompatible | |||
| github.com/zorkian/go-datadog-api v2.26.0+incompatible | |||
There was a problem hiding this comment.
Please rebase to latest master which already has this version.
There was a problem hiding this comment.
can do! I'll take care of this soon.
jackellenberger
force-pushed
the
add_template_variable_presets
branch
from
fc51f90
to
34566d4
Compare
|
@bkabrda done! Does this layout seem alright?
|
bkabrda
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit premature as zorkian/go-datadog-api#296 is still awaiting review, but I've confirmed it works when everything is hooked together properly:What
"Template Variable Presets" aka "Saved Views" are a quick shortcut that
can be added by hand or via json to dashboards in datadog, and appear in
the top left corner.
They allow you to string together common combinations of template
variable values, so if for example you want a "production us-east-2"
view of your dashboard, you could have a "production us-east-2" preset
that sets your template variables to
environment = productionandregion = us-east-2.This PR adds support for template variable presets to dashboards, using the
new SDK functionality linked to above.
Cheers!