Add aws log collection service resource #437
Conversation
ghost
added
the
|
Quick update: We are looking at this PR and we are trying to make sure with the proper team that this implementation is the right way to do this resource moving forward. We will come back to you very very soon. |
| func resourceDatadogIntegrationAwsLogCollectionExists(d *schema.ResourceData, meta interface{}) (b bool, e error) { | ||
| // Exists - This is called to verify a resource still exists. It is called prior to Read, | ||
| // and lowers the burden of Read to be able to assume the resource exists. | ||
| client := meta.(*datadog.Client) |
There was a problem hiding this comment.
You should cast the meta into a ProviderConfiguration like below, see other resources as example
providerConf := meta.(*ProviderConfiguration)
client := providerConf.CommunityClient
| } | ||
|
|
||
| func resourceDatadogIntegrationAwsLogCollectionCreate(d *schema.ResourceData, meta interface{}) error { | ||
| client := meta.(*datadog.Client) |
There was a problem hiding this comment.
dixit regarding the ProviderConfiguration
| } | ||
|
|
||
| func resourceDatadogIntegrationAwsLogCollectionUpdate(d *schema.ResourceData, meta interface{}) error { | ||
| client := meta.(*datadog.Client) |
There was a problem hiding this comment.
dixit regarding the ProviderConfiguration
| } | ||
|
|
||
| func resourceDatadogIntegrationAwsLogCollectionRead(d *schema.ResourceData, meta interface{}) error { | ||
| client := meta.(*datadog.Client) |
There was a problem hiding this comment.
dixit regarding the ProviderConfiguration
|
|
||
| logCollections, err := client.GetIntegrationAWSLogCollection() | ||
| if err != nil { | ||
| return false, err |
There was a problem hiding this comment.
Please use the translateClientError method to sanitize client error messages. translateClientError(err, "error getting aws integration log collection"). See examples in other resources.
|
|
||
| func checkIntegrationAWSLogCollectionDestroy(accProvider *schema.Provider) func(*terraform.State) error { | ||
| return func(s *terraform.State) error { | ||
| client := accProvider.Meta().(*datadog.Client) |
There was a problem hiding this comment.
providerConf := accProvider.Meta().(*ProviderConfiguration)
client := providerConf.CommunityClient
|
|
||
| func checkIntegrationAWSLogCollectionExists(accProvider *schema.Provider) func(*terraform.State) error { | ||
| return func(s *terraform.State) error { | ||
| client := accProvider.Meta().(*datadog.Client) |
There was a problem hiding this comment.
| client := accProvider.Meta().(*datadog.Client) | |
| providerConf := accProvider.Meta().(*ProviderConfiguration) | |
| client := providerConf.CommunityClient |
| if err != nil { | ||
| return err | ||
| } | ||
| for resourceType, r := range s.RootModule().Resources { |
There was a problem hiding this comment.
Could we create helper method like in here https://github.com/terraform-providers/terraform-provider-datadog/blob/master/datadog/resource_datadog_user_test.go#L68
| if err != nil { | ||
| return err | ||
| } | ||
| for _, r := range s.RootModule().Resources { |
There was a problem hiding this comment.
Helper method here for consistency as well :)
| return false, nil | ||
| } | ||
|
|
||
| func prepareDatadogIntegrationAwsLogCollectionRequest(d *schema.ResourceData) datadog.IntegrationAWSServicesLogCollection { |
There was a problem hiding this comment.
We usually name these method with the following convention buildSomethingStruct and we usually have it return a pointer.
func buildDatadogIntegrationAwsLogCollectionStruct(d *schema.ResourceData) *datadog.IntegrationAWSServicesLogCollection
The other half of #318. This resource allows the user to control which AWS services datadog will collect logs from. Related to https://github.com/terraform-providers/terraform-provider-datadog/pull/436.