Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dashboard_list resource to use Datadog Go client #479

Merged
merged 8 commits into from
Apr 30, 2020
Merged

Update Dashboard_list resource to use Datadog Go client #479

merged 8 commits into from
Apr 30, 2020

Conversation

skarimo
Copy link
Member

@skarimo skarimo commented Apr 29, 2020 •
edited by gzussa
Loading

Updates Dashboard_list to use Datadog GO client.

@ghost ghost added the size/XL label Apr 29, 2020
@gzussa gzussa changed the base branch from gzu/client to master April 29, 2020 14:17
gzussa
gzussa reviewed Apr 29, 2020
View reviewed changes
Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I have some questions listed below :)

datadog/resource_datadog_dashboard_list.go Outdated Show resolved Hide resolved
datadog/resource_datadog_dashboard_list_test.go Outdated Show resolved Hide resolved
datadog/resource_datadog_dashboard_list.go Outdated Show resolved Hide resolved
datadog/resource_datadog_dashboard_list.go Outdated Show resolved Hide resolved
@gzussa gzussa requested a review from bkabrda April 30, 2020 10:42
@gzussa gzussa merged commit bdd05d8 into DataDog:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzussa gzussa gzussa approved these changes

@bkabrda bkabrda Awaiting requested review from bkabrda

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skarimo @gzussa