Migrate AWS logs to use the official Go Client #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
nmuesch
requested changes
Apr 30, 2020
nmuesch
reviewed
Apr 30, 2020
jirikuncar
reviewed
May 8, 2020
| User-Agent: | ||
| - Datadog/dev/terraform (go1.13.4) | ||
| - datadog-api-client-go/1.0.0-beta.1+dev.1 (go go1.13; os darwin; arch amd64) |
There was a problem hiding this comment.
we need to update the User-Agent for datadog-api-client-go to terraform-provider-datadog/{version} datadog-api-client-go/1.0.0-beta.1+dev.1 (go go1.13; os darwin; arch amd64) format.
There was a problem hiding this comment.
I will do that in another PR because it will be too many changes for this PR. Good catch and let's update it once we have beta.3
There was a problem hiding this comment.
Could we instead ignore the user agent in the cassettes ? It's really system and version dependent, so not great for replaying as people won't always be running tests on the same system
There was a problem hiding this comment.
What I meant is that we are recording new cassette but the user-agent is not right.
jirikuncar
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.