Add default to deprecated count field to avoid sending 0
#514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
gzussa
approved these changes
May 12, 2020
|
I see that the default value is |
|
@terrificsoysauce so the widget has two sections - "Counts" and "List" (you can display them both or just one of them). The "Counts" section doesn't get affected by this setting, but the "List" does - it will indeed only display at max 50 monitors (using the default) even if there are more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The count field is set to 0 by terraform if not set, which prevents the widget from getting any data.
Since this field is marked as deprecated, it is not expected to be set, so having a default makes sense.