Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column revamp properties to dashboard log stream #517

Conversation

Prepager
Copy link
Contributor

@Prepager Prepager commented May 22, 2020

This PR adds four new properties to the dashboard log stream schema originating from the column revamp: show_date_column, show_message_column, message_display, and sort.

From: zorkian/go-datadog-api#321 DataDog/datadog-api-client-go@4f430b2

@ghost ghost added the size/M label May 22, 2020
Copy link
Contributor

@jbenais jbenais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for Dashboards, thank you! 💯
Would it just be possible to update the tests with the new properties?

@ghost ghost added size/XXL and removed size/M labels May 25, 2020
Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One type should be changed. Also we don't use the zorkian client anymore but this https://github.com/DataDog/datadog-api-client-go

datadog/resource_datadog_dashboard.go Outdated Show resolved Hide resolved
@nmuesch
Copy link
Contributor

nmuesch commented May 27, 2020

Thanks for the work on this @Prepager!! Could you also add these fields to the docs page here - https://github.com/terraform-providers/terraform-provider-datadog/blob/master/website/docs/r/dashboard.html.markdown under log_stream_definition and the example config?

@ghost ghost added the documentation label May 28, 2020
@Prepager Prepager requested a review from gzussa May 28, 2020 10:50
Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems great! Thanks!!

@gzussa gzussa merged commit 1287088 into DataDog:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants