-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add column revamp properties to dashboard log stream #517
Add column revamp properties to dashboard log stream #517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for Dashboards, thank you! 💯
Would it just be possible to update the tests with the new properties?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One type should be changed. Also we don't use the zorkian client anymore but this https://github.com/DataDog/datadog-api-client-go
Thanks for the work on this @Prepager!! Could you also add these fields to the docs page here - https://github.com/terraform-providers/terraform-provider-datadog/blob/master/website/docs/r/dashboard.html.markdown under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems great! Thanks!!
This PR adds four new properties to the dashboard log stream schema originating from the column revamp:
show_date_column
,show_message_column
,message_display
, andsort
.From:
zorkian/go-datadog-api#321DataDog/datadog-api-client-go@4f430b2