Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc for monitor datasource #585

Merged
merged 3 commits into from
Jul 21, 2020
Merged

Add doc for monitor datasource #585

merged 3 commits into from
Jul 21, 2020

Conversation

zippolyte
Copy link
Contributor

No description provided.

nmuesch
nmuesch reviewed Jul 20, 2020
View reviewed changes
website/docs/d/monitor.html.markdown Outdated
Retrieve information about an existing monitor.
---

# datadog_ip_ranges
Copy link
Contributor

@nmuesch nmuesch Jul 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# datadog_ip_ranges
# datadog_monitor_source

or something similar

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops 🙊

nmuesch
nmuesch reviewed Jul 20, 2020
View reviewed changes
Copy link
Contributor

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left one inline comment and I believe you'll have to add it here - https://github.com/terraform-providers/terraform-provider-datadog/blob/ee671b32271ef181dc09ae16d1010d1639a589f8/website/datadog.erb to show up in the side nav bar.

@therve
Copy link
Contributor

therve commented Jul 21, 2020

I think you need to reference it in datadog.erb too.

@ghost ghost added size/M and removed size/S labels Jul 21, 2020
therve
therve reviewed Jul 21, 2020
View reviewed changes
website/datadog.erb Outdated Show resolved Hide resolved
@zippolyte @therve
Update website/datadog.erb
72d71a4 
Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com>
@zippolyte zippolyte merged commit 1b15ccd into master Jul 21, 2020
@zippolyte zippolyte deleted the hippo/mds branch July 21, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmuesch nmuesch nmuesch left review comments

@therve therve therve approved these changes

Assignees
No one assigned
Labels
documentation size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zippolyte @therve @nmuesch