Fix various pylint warnings

(cherry picked from commit 7d20748)

Author: PierreRaybaut

datalab/gui/panel/base.py

@@ -217,11 +217,11 @@ def __init__(self, panel: BaseDataPanel, objclass: SignalObj | ImageObj) -> None
         self.analysis_parameters.setFont(font)
 
         # Track newly created objects to show Creation tab only once
-        self._newly_created_obj_uuid: str | None = None
+        self.newly_created_obj_uuid: str | None = None
         # Track when analysis results were just computed
-        self._fresh_analysis_obj_uuid: str | None = None
+        self.fresh_analysis_obj_uuid: str | None = None
         # Track when object was just processed (1-to-1)
-        self._fresh_processing_obj_uuid: str | None = None
+        self.fresh_processing_obj_uuid: str | None = None
 
         self.tabwidget.addTab(
             self.processing_history, get_icon("history.svg"), _("History")
@@ -455,23 +455,23 @@ def mark_as_newly_created(self, obj: SignalObj | ImageObj) -> None:
         Args:
             obj: Object to mark
         """
-        self._newly_created_obj_uuid = get_uuid(obj)
+        self.newly_created_obj_uuid = get_uuid(obj)
 
     def mark_as_freshly_processed(self, obj: SignalObj | ImageObj) -> None:
         """Mark object to show Processing tab on next selection.
 
         Args:
             obj: Object to mark
         """
-        self._fresh_processing_obj_uuid = get_uuid(obj)
+        self.fresh_processing_obj_uuid = get_uuid(obj)
 
     def mark_as_fresh_analysis(self, obj: SignalObj | ImageObj) -> None:
         """Mark object to show Analysis tab on next selection.
 
         Args:
             obj: Object to mark
         """
-        self._fresh_analysis_obj_uuid = get_uuid(obj)
+        self.fresh_analysis_obj_uuid = get_uuid(obj)
 
     def get_changed_properties(self) -> dict[str, Any]:
         """Get dictionary of properties that have changed from original values.
@@ -1532,9 +1532,9 @@ def add_object(
         # BUT: Don't overwrite if this object is already marked as freshly processed
         # or has fresh analysis results (those take precedence)
         obj_uuid = get_uuid(obj)
-        if (
-            obj_uuid != self.objprop._fresh_processing_obj_uuid
-            and obj_uuid != self.objprop._fresh_analysis_obj_uuid
+        if obj_uuid not in (
+            self.objprop.fresh_processing_obj_uuid,
+            self.objprop.fresh_analysis_obj_uuid,
         ):
             self.objprop.mark_as_newly_created(obj)
 
@@ -2474,17 +2474,17 @@ def selection_changed(self, update_items: bool = False) -> None:
         if current_obj is not None:
             obj_uuid = get_uuid(current_obj)
             # Show Creation tab for newly created objects (only once)
-            if obj_uuid == self.objprop._newly_created_obj_uuid:
+            if obj_uuid == self.objprop.newly_created_obj_uuid:
                 force_tab = "creation"
-                self.objprop._newly_created_obj_uuid = None
+                self.objprop.newly_created_obj_uuid = None
             # Show Processing tab for freshly processed objects (only once)
-            elif obj_uuid == self.objprop._fresh_processing_obj_uuid:
+            elif obj_uuid == self.objprop.fresh_processing_obj_uuid:
                 force_tab = "processing"
-                self.objprop._fresh_processing_obj_uuid = None
+                self.objprop.fresh_processing_obj_uuid = None
             # Show Analysis tab for objects with fresh analysis results
-            elif obj_uuid == self.objprop._fresh_analysis_obj_uuid:
+            elif obj_uuid == self.objprop.fresh_analysis_obj_uuid:
                 force_tab = "analysis"
-                self.objprop._fresh_analysis_obj_uuid = None
+                self.objprop.fresh_analysis_obj_uuid = None
 
         self.objprop.update_properties_from(current_obj, force_tab=force_tab)
         self.acthandler.selected_objects_changed(selected_groups, selected_objects)

datalab/tests/features/common/coordutils_unit_test.py

@@ -75,7 +75,7 @@ def test_round_image_coords():
     assert rounded == [10.0, 21.0, 31.0, 40.0]
 
     # Test with empty coords
-    assert round_image_coords(img, []) == []
+    assert not round_image_coords(img, [])
 
     # Test error for odd number of coordinates
     with pytest.raises(ValueError, match="even number of elements"):

datalab/tests/features/macro/macroeditor_unit_test.py

@@ -25,7 +25,7 @@
 
 from datalab.env import execenv
 from datalab.gui.macroeditor import Macro
-from datalab.gui.panel import macro
+from datalab.gui.panel.macro import MacroPanel
 from datalab.tests import datalab_test_app_context, helpers
 
 
@@ -56,7 +56,7 @@ def get_macro_example_path() -> str:
 def test_macro_editor():
     """Test dep viewer window"""
     with qt_app_context(exec_loop=True):
-        widget = macro.MacroPanel(None)
+        widget = MacroPanel(None)
         widget.resize(800, 600)
         widget.show()
 

datalab/widgets/instconfviewer.py

@@ -89,8 +89,8 @@ def get_manifest_package_info(manifest_path: Path) -> str:
             result_lines.append(f"{name:{name_width}}   {version:{version_width}}")
 
         return os.linesep.join(result_lines)
-    except Exception as e:
-        return f"Error reading manifest file: {e}"
+    except Exception as exc:  # pylint: disable=broad-except
+        return f"Error reading manifest file: {exc}"
 
 
 def get_install_info() -> str: