-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking changes in 2.0.0 #60
Comments
@FSMaxB just to clarify: Version 1.0.0 should be: 3a7bd69 Your new release, which requires code changes, should be 2.0.0. You're welcome to make it a separate project, but until it's tested, working, and everything is done, head MUST point to that commit. |
Understood. I will release 1.0.0 with the build system improvements ( but without the breaking changes. That includes the library version. |
You are AWESOME. Thanks :) |
It might be useful to return an error position instead of an error pointer. That would help to prevent pointers to invalid memory (in case the input string gets freed, but the error pointer is still around). If a user of the library wants the old error pointer the user would just add the error position to the beginning of the json string. |
With 2.0.0 let's try to get things right with the following breaking changes:
size_t
instead ofint
for lengthscJSON_InitHooks
in favor of Need public API to free returned strings (e.g. cJSON_Print) #5cJSON_GetErrorPtr
in favor of Get rid of the global error pointer and replace it with a local one that gets passed to functions manually #59cJSON_CreateIntArray
,cJSON_CreateFloatArray
andcJSON_CreateDoubleArray
in favor of acJSON_CreateNumberArray
macro???realloc
support. (fall back to malloc if not specified available)cJSON_AddItemToObject
and other void functions Problem with cJSON_AddItem* functions #107void *
pointer with user data that get's passed through.cJSON_PrintPreallocated
: Return size and useunsigned char*
The text was updated successfully, but these errors were encountered: