Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable autosorting of nodes #13

Open
Chaoschaot232 opened this issue Oct 6, 2022 · 3 comments
Open

Disable autosorting of nodes #13

Chaoschaot232 opened this issue Oct 6, 2022 · 3 comments

Comments

@Chaoschaot232
Copy link

I am not sure why this feature is in as it disrupts the clean reading of the production line so please remove anything
related to an automaticly adjusting of any node since I don't want this and it is also not needed.

If it's not going to be removed, then add an option to disable this useless functionalty, thanks.

@rpetre
Copy link

rpetre commented Oct 6, 2022

I'm fairly certain this repo wasn't yet meant for public consumption, the author started working on it for his own use and kinda abandoned it midway, so it's no use arguing about polish.

I kinda hope he picks it back up, I made some local changes for my own use but I haven't worked with React at all before, I just murdered his code until it almost did what I wanted.

@David-Melo
Copy link
Owner

Hello,

I did link the repo on the app to get feedback like this, so thanks. I had to step away from the game to focus on some work projects, so I have been unable to make any updates or even play the games.

I'm thinking of adding a toggle to prevent to auto-sorting. Although I'm not sure how that would affect it. Since the nodes are added dynamically, it kind of needs to calculate where to place the new ones so they don't overlap. but maybe that can be done without re-organizing the previous ones.

I also have to export the latest data from the game since I think the recipes have been rebalanced.

@rpetre If you'd like to open up a pull request or another issue to discuss the changes you've made, maybe I can merge in if you've made improvements.

When I started this it was early summer and my workload was very light, but I have missed playing the game.

@rpetre
Copy link

rpetre commented Oct 6, 2022

Nice to see you back ;) We talked a bit about this on a reddit thread a couple of months ago and I was watching the repo. There are obviously some design choices that you started with that are not quite intuitive so I was hoping you would pick it up and work on them a bit more.

In the meantime I tried to hack locally (my goal is to discover building ratios for various production chains and also identify the steps that have higher throughput to avoid using trucks for those, so maybe a bit different than your idea). Since it's my first time interacting with React I just hacked at random various stuff so maybe it's not worth opening a PR or publishing a fork.

I'll try to gather a list of observations or ideas I had in a different issue in a day or two, maybe we can identify some stuff there worth working towards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants