Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with error determination in the FastFit #2

Open
mmosc opened this issue Apr 5, 2019 · 0 comments
Open

issue with error determination in the FastFit #2

mmosc opened this issue Apr 5, 2019 · 0 comments

Comments

@mmosc
Copy link

mmosc commented Apr 5, 2019

Hi David,
I think there is a problem in the determination of the errors for the FastFit.
You solve:

err_l = brentq(lambda x: -2*fit.log_likelihood([x]) - 1, a=0.03, b=bf['x'])

err_r = brentq(lambda x: -2*fit.log_likelihood([x]) - 1, a=bf['x'], b=0.05)

but we should actually solve Delta Chi^2 == 0, i.e.:

err_l = brentq(lambda x: -2*(fit.log_likelihood([x])-bf['log_likelihood']) - 1 , a=0.03, b=bf['x'])
err_r = brentq(lambda x: -2*(fit.log_likelihood([x])-bf['log_likelihood']) - 1 , a=bf['x'], ##b=0.05)
Best,
Marta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant