Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeRange CustomField isn't parsed properly #123

Closed
paw-eloquent-safe opened this issue Jul 20, 2022 · 3 comments · Fixed by #130
Closed

TimeRange CustomField isn't parsed properly #123

paw-eloquent-safe opened this issue Jul 20, 2022 · 3 comments · Fixed by #130
Assignees
Labels
bug Something isn't working pipedrive Pipedrive API bug

Comments

@paw-eloquent-safe
Copy link

Describe the bug
When handling a PipeDrive response with a TimeRange Custom Field.
The function CustomFieldConverter.ReadJson() throws an exception since it tries to parse an time span represented as an string as an integer.

To Reproduce
Steps to reproduce the behavior:

  1. Add a custom TimeRange field to your deal.
  2. Create a deal.
  3. Mutate/edit/update the deal using PipedriveApiClient.Deal.Edit(), while making sure to set the custom TimeRange field you just created.
  4. Wait for the response to be recieved/parsed.
  5. Error while deserializing.

Expected behavior
I expected pipedrive-dotnet to parse this as an timespan not an integer.

Screenshots
image
image

Version Info
0.5.18 from NuGet.

@DavidRouyer DavidRouyer added the bug Something isn't working label Oct 11, 2022
@DavidRouyer DavidRouyer self-assigned this Oct 11, 2022
@DavidRouyer
Copy link
Owner

Thank you for your bug report, it looks like the timezone_id isn't an int anymore

@DavidRouyer
Copy link
Owner

Pipedrive.net v0.5.19 has been released https://github.com/DavidRouyer/pipedrive-dotnet/releases/tag/v0.5.19

@paw-eloquent-safe
Copy link
Author

Pipedrive.net v0.5.19 has been released https://github.com/DavidRouyer/pipedrive-dotnet/releases/tag/v0.5.19

tyvm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pipedrive Pipedrive API bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants