Don't create subscriptions in reg-sub #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where reg-sub created subscriptions and closed over them when using the `:<- [:sub]` sugar. Now dependent subscriptions aren't created until they are needed, and they will be cleaned up correctly.
danielcompton
added a commit
that referenced
this pull request
Oct 25, 2016
danielcompton
added a commit
that referenced
this pull request
Nov 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where reg-sub created subscriptions and closed over them when using the
:<- [:sub]sugar. Now dependent subscriptions aren't created until they are needed, and they will be cleaned up correctly.I'm not 100% sold on my tests for this behaviour, but I'm not sure how/if I want to hook into the Reagent guts to check this further.